Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 24, 2025


PR-Codex overview

This PR focuses on removing the @description tag from various JSDoc comments across multiple files, streamlining the documentation without altering the content or meaning of the comments.

Detailed summary

  • Removed @description tag from JSDoc comments in:
    • is-erc6492-signature.ts
    • download.ts
    • addSigner.ts
    • addSignerFor.ts
    • parse-erc6492-signature.ts
    • registerFidAndSigner.ts
    • verify-signature.ts
    • linkAccount.ts
    • unlinkAccount.ts
    • verify-hash.ts
    • type-utils.ts
    • serialize-erc6492-signature.ts
    • verify-typed-data.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:52pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:52pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:52pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:52pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: ece47c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 24, 2025 19:43
@MananTank MananTank requested review from a team as code owners April 24, 2025 19:43
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 344 ms (+84.6% 🔺) 1.4 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 652 ms (+11.59% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 224 ms (+1611.95% 🔺) 337 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 80 ms (+1638.43% 🔺) 90 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 189 ms (+411.89% 🔺) 576 ms

@joaquim-verges joaquim-verges merged commit b6fdd0c into main Apr 24, 2025
22 of 23 checks passed
@joaquim-verges joaquim-verges deleted the 04-25-sdk_remove_description_tags_from_jsdoc branch April 24, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants