Skip to content

Fix: useWalletBalance and the useActiveAccount to work with 0x{string} addresses instead of strings. #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: useWalletBalance and the useActiveAccount to work with 0x{string} addresses instead of strings. #6852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/thirdweb/src/adapters/viem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@
);
}
return {
address: viemAccount.address,
address: viemAccount.address as `0x${string}`,

Check warning on line 397 in packages/thirdweb/src/adapters/viem.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/adapters/viem.ts#L397 

Added line #L397 was not covered by tests
signMessage: async (msg) => {
return options.walletClient.signMessage({
account: viemAccount,
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/react/core/hooks/others/useWalletBalance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {

type UseWalletBalanceOptions = Prettify<
Omit<GetWalletBalanceOptions, "address" | "chain"> & {
address: string | undefined;
address: `0x${string}` | undefined;
chain: Chain | undefined;
}
>;
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/react/native/ui/connect/TokenListScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const TokenRow = (props: {
theme: Theme;
client: ThirdwebClient;
chain?: Chain;
address?: string;
address?: `0x${string}`;
onTokenSelected?: (token?: TokenInfo) => void;
}) => {
const { token, theme, address, chain, client, onTokenSelected } = props;
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/wallets/engine/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type EngineAccountOptions = {
/**
* The backend wallet to use for sending transactions inside engine.
*/
walletAddress: string;
walletAddress: `0x${string}`;
overrides?: {
/**
* The address of the smart account to act on behalf of. Requires your backend wallet to be a valid signer on that smart account.
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/wallets/interfaces/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export type Account = {
/**
* address of the account
*/
address: Address;
address: `0x${string}`;
/**
* Send the given transaction to the blockchain
* @example
Expand Down
Loading