Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 25, 2025


PR-Codex overview

This PR focuses on enhancing the UI and functionality of the ExecuteTransactionCard component in a dashboard application. It improves the styling of various elements and refines the transaction handling logic.

Detailed summary

  • Updated the styling of div elements to improve border visibility.
  • Changed the font weight of span elements for "From", "To", "Value", and "Status" to font-medium.
  • Modified the transaction hash display for better clarity.
  • Refined transaction handling logic, including status updates and event tracking during transaction execution.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 4:10pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 4:10pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 4:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 4:10pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 4:10pm

@linear
Copy link

linear bot commented Apr 25, 2025

@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 15:51 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: bb554e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 15:51 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (90823ef) to head (bb554e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6859   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank marked this pull request as ready for review April 25, 2025 15:54
@MananTank MananTank requested review from a team as code owners April 25, 2025 15:54
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 174 ms (+168.16% 🔺) 1.2 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 285 ms (+74.32% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 62 ms (+1464% 🔺) 175 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 20 ms (+987.32% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 111 ms (+558.7% 🔺) 497 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the UI and functionality of the `ExecuteTransactionCard` component in the dashboard app. It includes visual improvements and adjustments to transaction handling.

### Detailed summary
- Updated the border styling for child elements in the main `div`.
- Changed text styles for labels (`From`, `To`, `Value`, `Status`, and `Transaction Hash`) to use `font-medium`.
- Added a conditional rendering for the footer based on transaction status.
- Improved transaction tracking event labels.
- Refactored the transaction submission logic for clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 16:03 Inactive
@graphite-app graphite-app bot merged commit bb554e5 into main Apr 25, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-211 branch April 25, 2025 16:11
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 16:11 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 16:11 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 16:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants