Skip to content

[NEB-191] Nebula, Dashboard: Reduce vertical spacing in markdown renderer #6860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

[NEB-191] Nebula, Dashboard: Reduce vertical spacing in markdown renderer #6860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/src/app/nebula-app/(app)/components/Chats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ function StyledMarkdownRenderer(props: {
p={{
className:
props.type === "assistant"
? "text-foreground leading-loose"
? "text-foreground"
: "text-foreground leading-normal",
}}
li={{ className: "text-foreground" }}
Expand Down
4 changes: 2 additions & 2 deletions apps/dashboard/src/app/nebula-app/(app)/components/ExecuteTransactionCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function ExecuteTransactionCardLayout(props: {
</h3>

{/* content */}
<div className="px-4 text-sm lg:px-6 [&>*:not(:last-child)]:border-b [&>*]:h-12 lg:[&>*]:h-14">
<div className="px-4 text-sm lg:px-6 [&>*:not(:last-child)]:border-b [&>*]:h-[52px]">
{/* From */}
<div className="flex items-center justify-between gap-2">
<span className="font-medium text-muted-foreground">From</span>
Expand Down Expand Up @@ -229,7 +229,7 @@ export function ExecuteTransactionCardLayout(props: {

{/* footer */}
{props.status.type !== "confirmed" && (
<div className="flex items-center justify-end border-t px-4 py-6 lg:px-6">
<div className="flex items-center justify-end border-t px-4 py-5 lg:px-6">
<TransactionButton
isPending={sendTransaction.isPending}
transactionCount={undefined}
Expand Down
17 changes: 10 additions & 7 deletions apps/dashboard/src/components/contract-components/published-contract/markdown-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ export const MarkdownRenderer: React.FC<{
skipHtml?: boolean;
}> = (markdownProps) => {
const { markdownText, className, code } = markdownProps;
const commonHeadingClassName =
"mb-2 pb-2 leading-5 font-semibold tracking-tight";
const commonHeadingClassName = "mb-2 leading-5 font-semibold tracking-tight";

return (
<div className={className}>
Expand All @@ -49,7 +48,7 @@ export const MarkdownRenderer: React.FC<{
<h2
className={cn(
commonHeadingClassName,
"mb-3 border-border border-b text-xl md:text-2xl",
"mb-3 border-border border-b pb-2 text-xl md:text-2xl",
)}
{...cleanedProps(props)}
/>
Expand All @@ -60,7 +59,7 @@ export const MarkdownRenderer: React.FC<{
{...cleanedProps(props)}
className={cn(
commonHeadingClassName,
"mt-8 mb-3 border-border border-b text-lg md:text-xl",
"mt-8 mb-3 border-border border-b pb-2 text-lg md:text-xl",
)}
/>
),
Expand Down Expand Up @@ -105,6 +104,10 @@ export const MarkdownRenderer: React.FC<{
/>
),

hr: (props) => (
<hr {...cleanedProps(props)} className="my-5 bg-border" />
),

code: ({ ...props }) => {
const codeStr = onlyText(props.children);

Expand Down Expand Up @@ -180,21 +183,21 @@ export const MarkdownRenderer: React.FC<{
ul: (props) => {
return (
<ul
className="mb-6 list-outside list-disc pl-5 [&_ol_li:first-of-type]:mt-1.5 [&_ul_li:first-of-type]:mt-1.5"
className="mb-4 list-outside list-disc pl-5 [&_ol_li:first-of-type]:mt-1.5 [&_ul_li:first-of-type]:mt-1.5"
{...cleanedProps(props)}
/>
);
},
ol: (props) => (
<ol
className="mb-6 list-outside list-decimal pl-5 [&_ol_li:first-of-type]:mt-1.5 [&_ul_li:first-of-type]:mt-1.5"
className="mb-4 list-outside list-decimal pl-5 [&_ol_li:first-of-type]:mt-1.5 [&_ul_li:first-of-type]:mt-1.5"
{...cleanedProps(props)}
/>
),
li: ({ children: c, ...props }) => (
<li
className={cn(
"mb-2 text-muted-foreground leading-loose [&>p]:m-0",
"mb-1.5 text-muted-foreground leading-loose [&>p]:m-0",
markdownProps.li?.className,
)}
{...cleanedProps(props)}
Expand Down
Loading