[NEB-196] Tx button improvements: hide switch chain and approve tx popovers when possible #6863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Apr 25, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6863 +/- ##
=======================================
Coverage 55.31% 55.31%
=======================================
Files 896 896
Lines 57024 57024
Branches 3968 3968
=======================================
Hits 31542 31542
Misses 25385 25385
Partials 97 97
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Apr 25, 2025
Contributor
Merge activity
|
…povers when possible (#6863) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `TransactionButton` and `MismatchButton` components by incorporating wallet connection status and improving transaction handling. It introduces logic for determining if a transaction requires external confirmation based on the connected wallets. ### Detailed summary - Added `useConnectedWallets` to `TransactionButton`. - Introduced `canSendTransactionWithoutConfirmation` function to check if a wallet can send transactions without confirmation. - Removed `isGasless` prop from `TransactionButton`. - Updated `MismatchButton` to include `isPending` prop. - Added connection status handling in `MismatchButton`. - Enhanced transaction handling based on network mismatch and wallet conditions. - Implemented `canSwitchNetworkWithoutConfirmation` function to determine switching requirements. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
neb-215
branch
from
f530be0 to
2d27c4f
Compare
graphite-app
bot
force-pushed
the
neb-196
branch
from
ff0cb29 to
fee560a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
TransactionButtonandMismatchButtoncomponents by introducing new wallet connection logic and improving user experience during network mismatches. It adds functionality to check if transactions can be sent without confirmation and updates button behavior accordingly.Detailed summary
useConnectedWalletstoTransactionButton.canSendTransactionWithoutConfirmationfunction to determine if a transaction requires confirmation.isGaslessprop fromTransactionButton.MismatchButtonto handle wallet connection status and network mismatches.isPendingprop toMismatchButton.MismatchButton.