Skip to content

[NEB-229] Nebula: follow-up prompt improvements, preserve reasoning UI on error #6925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

[NEB-229] Nebula: follow-up prompt improvements, preserve reasoning UI on error #6925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,6 @@ export function ChatPageContent(props: {
chatAbortController?.abort();
setChatAbortController(undefined);
setIsChatStreaming(false);
// if last message is presence, remove it
if (messages[messages.length - 1]?.type === "presence") {
setMessages((prev) => prev.slice(0, -1));
}
}}
context={contextFilters}
setContext={(v) => {
Expand Down
18 changes: 15 additions & 3 deletions apps/dashboard/src/app/nebula-app/(app)/components/Chats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ export function Chats(props: {
isMessagePending={isMessagePending}
client={props.client}
sendMessage={props.sendMessage}
nextMessage={props.messages[index + 1]}
/>
</ScrollShadow>

Expand Down Expand Up @@ -207,8 +208,9 @@ function RenderMessage(props: {
isMessagePending: boolean;
client: ThirdwebClient;
sendMessage: (message: string) => void;
nextMessage: ChatMessage | undefined;
}) {
const { message, isMessagePending, client, sendMessage } = props;
const { message, isMessagePending, client, sendMessage, nextMessage } = props;

switch (message.type) {
case "assistant":
Expand Down Expand Up @@ -237,6 +239,11 @@ function RenderMessage(props: {
txData={message.data}
client={client}
onTxSettled={(txHash) => {
// do not send automatic prompt if there is another transaction after this one
if (nextMessage?.type === "action") {
return;
}

sendMessage(getTransactionSettledPrompt(txHash));
}}
/>
Expand All @@ -254,8 +261,13 @@ function RenderMessage(props: {
<SwapTransactionCard
swapData={message.data}
client={client}
onTxSettled={() => {
// no op
onTxSettled={(txHash) => {
// do not send automatic prompt if there is another transaction after this one
if (nextMessage?.type === "action") {
return;
}

sendMessage(getTransactionSettledPrompt(txHash));
}}
/>
);
Expand Down
Loading