Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 2, 2025


PR-Codex overview

This PR focuses on updating the fee data in the packages/thirdweb/src/gas/fee-data.ts file by adding new entries for the Ronin Mainnet and Ronin Testnet.

Detailed summary

  • Added 2020 for Ronin Mainnet.
  • Added 2021 for Ronin Testnet (Saigon).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper requested review from a team as code owners May 2, 2025 13:16
@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: bbcd72c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:24pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:24pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:24pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:24pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:24pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (-0.02% 🔽) 1.1 s (-0.02% 🔽) 296 ms (+215.26% 🔺) 1.4 s
thirdweb (cjs) 143.09 KB (+0.05% 🔺) 2.9 s (+0.05% 🔺) 483 ms (+90.13% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 132 ms (+1665.47% 🔺) 246 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 44 ms (+1656.74% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 145 ms (+650.16% 🔺) 534 ms

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (3b9a412) to head (bbcd72c).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6927      +/-   ##
==========================================
- Coverage   55.21%   55.02%   -0.19%     
==========================================
  Files         896      897       +1     
  Lines       57057    57298     +241     
  Branches     3957     3955       -2     
==========================================
+ Hits        31502    31527      +25     
- Misses      25459    25674     +215     
- Partials       96       97       +1     
Flag Coverage Δ
packages 55.02% <100.00%> (-0.19%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/gas/fee-data.ts 73.05% <100.00%> (+0.32%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 6745ba0 into main May 3, 2025
24 checks passed
@joaquim-verges joaquim-verges deleted the firekeeper/ronin branch May 3, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants