Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 5, 2025

Taken from:

https://x.com/dillionverma/status/1917639091228926311


PR-Codex overview

This PR focuses on updating the lucide-react icon imports across various files, replacing old icon names with new standardized names, and adding new type definitions for lucide-react. It also modifies the TypeScript configuration to include the new definitions.

Detailed summary

  • Added lucide-react.d.ts type definitions in multiple apps.
  • Updated icon imports from lucide-react to follow a standardized naming convention (e.g., ChevronDown to ChevronDownIcon).
  • Modified tsconfig.json files to include the new type definitions.
  • Adjusted icon usage in various components for consistency and clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:58am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:58am

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2025

⚠️ No Changeset found

Latest commit: 54ef396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review May 5, 2025 23:24
@MananTank MananTank requested review from a team, jnsdls and joaquim-verges as code owners May 5, 2025 23:24
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. labels May 5, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (bda0f3e) to head (9d40b13).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6950   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57342           
  Branches     3967     3967           
=======================================
  Hits        31558    31558           
  Misses      25687    25687           
  Partials       97       97           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 191 ms (+173.67% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 331 ms (+91.99% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 92 ms (+1861.77% 🔺) 206 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 24 ms (+1218.26% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 97 ms (+522.29% 🔺) 486 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants