Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 6, 2025


PR-Codex overview

This PR focuses on deprecating legacy payment functions in the thirdweb package and updating various components across the codebase to enhance functionality and maintainability.

Detailed summary

  • Added @deprecated tag to multiple functions in thirdweb related to payment:
    • getBuyWithCryptoQuote
    • getPostOnRampQuote
    • getBuyWithCryptoTransfer
    • getBuyWithCryptoStatus
    • getBuyWithCryptoHistory
    • useBuyWithFiatQuote
    • useBuyWithFiatStatus
    • useBuyWithFiatHistory
    • useBuyWithCryptoQuote
    • useBuyWithCryptoStatus
    • useBuyWithCryptoHistory
  • Updated logic for selectedDoc in apps/portal/src/app/typescript/v5/[...slug]/page.tsx and apps/portal/src/app/references/components/TDoc/PageLayout.tsx to include a fallback for slugToDoc.
  • Changed sidebar structure in apps/portal/src/app/typescript/v5/sidebar.tsx to categorize payment links under "Bridge, Swap, and Onramp".
  • Updated the Universal Bridge section in apps/portal/src/app/connect/pay/overview/page.mdx to clarify its capabilities.
  • Enhanced webhook documentation in apps/portal/src/app/connect/pay/webhooks/page.mdx for better clarity on webhook implementation and verification.
  • Various updates to the TypedocSummary component to include key props for React elements to prevent potential rendering issues.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 6, 2025 01:43
@linear
Copy link

linear bot commented May 6, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: b282750

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:33am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:33am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:33am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:33am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:33am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels May 6, 2025
@gregfromstl gregfromstl force-pushed the greg/tool-4245-broken-links-in-for-universal-bridge-both-these-go-to-broken branch 2 times, most recently from 9f1ce8c to 9e7b45e Compare May 6, 2025 01:44
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (0%) 1.1 s (0%) 162 ms (+143.81% 🔺) 1.2 s
thirdweb (cjs) 143.09 KB (0%) 2.9 s (0%) 280 ms (+67.66% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 75 ms (+1472.12% 🔺) 188 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 19 ms (+1036% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 76 ms (+355.75% 🔺) 465 ms

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (2c6bd62) to head (b282750).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6952      +/-   ##
==========================================
- Coverage   55.01%   55.01%   -0.01%     
==========================================
  Files         897      897              
  Lines       57309    57309              
  Branches     3956     3960       +4     
==========================================
- Hits        31531    31530       -1     
- Misses      25681    25682       +1     
  Partials       97       97              
Flag Coverage Δ
packages 55.01% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...kages/thirdweb/src/pay/buyWithCrypto/getHistory.ts 8.00% <ø> (ø)
...ackages/thirdweb/src/pay/buyWithCrypto/getQuote.ts 5.47% <ø> (ø)
...ckages/thirdweb/src/pay/buyWithCrypto/getStatus.ts 7.14% <ø> (ø)
...ages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts 7.14% <ø> (ø)
...thirdweb/src/pay/buyWithFiat/getPostOnRampQuote.ts 5.00% <ø> (ø)
packages/thirdweb/src/pay/buyWithFiat/getQuote.ts 6.97% <ø> (ø)
packages/thirdweb/src/pay/buyWithFiat/getStatus.ts 8.33% <ø> (ø)
...eb/src/pay/buyWithFiat/isSwapRequiredPostOnramp.ts 5.26% <ø> (ø)
.../src/react/core/hooks/pay/useBuyWithCryptoQuote.ts 15.00% <ø> (ø)
...src/react/core/hooks/pay/useBuyWithCryptoStatus.ts 13.04% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 6, 2025 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 02:10 Inactive
gregfromstl and others added 4 commits May 5, 2025 19:22
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: greg <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: greg <[email protected]>
@gregfromstl gregfromstl force-pushed the greg/tool-4245-broken-links-in-for-universal-bridge-both-these-go-to-broken branch from 71c30d4 to b282750 Compare May 6, 2025 02:22
@gregfromstl gregfromstl merged commit 055e451 into main May 6, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4245-broken-links-in-for-universal-bridge-both-these-go-to-broken branch May 6, 2025 02:46
@joaquim-verges joaquim-verges mentioned this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants