Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 6, 2025


PR-Codex overview

This PR introduces a maxSteps option to the Buy and Sell functions, allowing users to limit quotes to routes with a specified number of steps, enhancing control over transaction paths.

Detailed summary

  • Added maxSteps option to Buy.quote, Buy.prepare, Sell.quote, and Sell.prepare functions.
  • Updated examples in documentation to illustrate usage of maxSteps.
  • Enhanced tests to verify functionality of maxSteps in both Sell and Buy modules.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 6, 2025 03:06
@linear
Copy link

linear bot commented May 6, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 0fd6902

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 6, 2025
@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🛑 Canceled (Inspect) May 6, 2025 3:25am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:25am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:25am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:25am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:25am

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.02 KB (+0.2% 🔺) 1.1 s (+0.2% 🔺) 298 ms (+174.66% 🔺) 1.4 s
thirdweb (cjs) 143.06 KB (-0.02% 🔽) 2.9 s (-0.02% 🔽) 462 ms (+88.73% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 123 ms (+1627.85% 🔺) 237 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 25 ms (+503.93% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 95 ms (+379.49% 🔺) 485 ms

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (055e451) to head (0fd6902).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6953      +/-   ##
==========================================
+ Coverage   55.01%   55.02%   +0.01%     
==========================================
  Files         897      897              
  Lines       57309    57323      +14     
  Branches     3960     3963       +3     
==========================================
+ Hits        31530    31544      +14     
  Misses      25682    25682              
  Partials       97       97              
Flag Coverage Δ
packages 55.02% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/bridge/Buy.ts 96.52% <100.00%> (+0.22%) ⬆️
packages/thirdweb/src/bridge/Sell.ts 97.39% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl merged commit 736c3f8 into main May 6, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4383-add-maxsteps-to-quote-and-prepare-endpoints branch May 6, 2025 03:25
@joaquim-verges joaquim-verges mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants