Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 6, 2025


PR-Codex overview

This PR introduces the sortBy option for the Bridge.routes method in the thirdweb library, allowing users to sort routes by popularity. Additionally, it updates related documentation and parameter definitions across several files.

Detailed summary

  • Added sortBy option to Bridge.routes for sorting by popularity.
  • Updated parameter documentation in Sell.ts, Buy.ts, and Routes.ts to include maxSteps and sortBy.
  • Enhanced example usage in Routes.ts to demonstrate the new sortBy functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 6, 2025 05:07
@linear
Copy link

linear bot commented May 6, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 0afc5da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 6, 2025 5:14am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 5:14am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 5:14am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 5:14am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 5:14am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.96 KB (-0.12% 🔽) 1.1 s (-0.12% 🔽) 144 ms (+121.55% 🔺) 1.2 s
thirdweb (cjs) 143.17 KB (+0.08% 🔺) 2.9 s (+0.08% 🔺) 247 ms (+31.5% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 39 ms (+599.88% 🔺) 152 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 12 ms (+459.88% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 67 ms (+419.51% 🔺) 456 ms

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.03%. Comparing base (736c3f8) to head (0afc5da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/bridge/Routes.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6955   +/-   ##
=======================================
  Coverage   55.02%   55.03%           
=======================================
  Files         897      897           
  Lines       57323    57327    +4     
  Branches     3963     3964    +1     
=======================================
+ Hits        31544    31551    +7     
+ Misses      25682    25680    -2     
+ Partials       97       96    -1     
Flag Coverage Δ
packages 55.03% <25.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/bridge/Buy.ts 96.52% <ø> (ø)
packages/thirdweb/src/bridge/Sell.ts 97.39% <ø> (ø)
packages/thirdweb/src/bridge/Routes.ts 87.50% <25.00%> (-5.69%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl merged commit 6dd2b09 into main May 6, 2025
22 of 24 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4382-routespopular-endpoint branch May 6, 2025 05:15
@joaquim-verges joaquim-verges mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants