Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 6, 2025


PR-Codex overview

This PR modifies the rendering logic of a heading in the Function component of the TDoc module. It updates how the heading text is constructed based on the presence and value of extensionName.

Detailed summary

  • Changes the conditional rendering of the heading text in the Heading component.
  • Updates the text to include extensionName only if it is defined and not equal to "Common".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 6, 2025 06:56
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: b3850ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 6, 2025 6:56am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 6, 2025 6:56am
thirdweb_playground ⬜️ Skipped (Inspect) May 6, 2025 6:56am
thirdweb-www ⬜️ Skipped (Inspect) May 6, 2025 6:56am
wallet-ui ⬜️ Skipped (Inspect) May 6, 2025 6:56am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl merged commit 3a100c9 into main May 6, 2025
11 of 12 checks passed
@gregfromstl gregfromstl deleted the fix/docs-extension-name branch May 6, 2025 06:56
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (08cff4b) to head (b3850ad).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6957   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57342           
  Branches     3966     3966           
=======================================
  Hits        31561    31561           
  Misses      25684    25684           
  Partials       97       97           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 200 ms (+216.9% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 340 ms (+80.66% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 77 ms (+1352.48% 🔺) 190 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 19 ms (+741.15% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 92 ms (+714.78% 🔺) 481 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants