Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 6, 2025


PR-Codex overview

This PR introduces a new type, CheckoutParams, to define parameters for the checkout process and enhances the ThemeHandler component to manage themes based on URL search parameters. It also updates the CheckoutLayout and CheckoutEmbed components to support the new parameters.

Detailed summary

  • Added CheckoutParams type in types.ts for checkout parameters.
  • Implemented ThemeHandler in ThemeHandler.client.tsx to set themes based on URL search parameters.
  • Updated CheckoutLayout to use async and include ThemeHandler within a Suspense component.
  • Modified CheckoutEmbed to accept theme, name, and image from CheckoutParams.
  • Refactored RoutesPage to utilize CheckoutParams for parameter validation and extraction.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 10:26am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 6, 2025 10:26am
login ⬜️ Skipped (Inspect) May 6, 2025 10:26am
thirdweb_playground ⬜️ Skipped (Inspect) May 6, 2025 10:26am
wallet-ui ⬜️ Skipped (Inspect) May 6, 2025 10:26am

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 10:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 10:03 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: 0bba535

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 10:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 10:03 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 6, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 6, 2025 10:03
@joaquim-verges joaquim-verges requested review from a team as code owners May 6, 2025 10:03
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (dfa3ee0) to head (0bba535).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6958   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57342           
  Branches     3967     3967           
=======================================
  Hits        31558    31558           
  Misses      25687    25687           
  Partials       97       97           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 259 ms (+183.53% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 463 ms (+72.99% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 105 ms (+1459.26% 🔺) 218 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 31 ms (+624.41% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 127 ms (+501.39% 🔺) 516 ms

@joaquim-verges joaquim-verges force-pushed the _Checkout_Add_theme_support_and_improve_client_configuration branch from 485b7fe to 0bba535 Compare May 6, 2025 10:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 10:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 10:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 10:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 10:19 Inactive
@joaquim-verges joaquim-verges merged commit bda0f3e into main May 6, 2025
24 checks passed
@joaquim-verges joaquim-verges deleted the _Checkout_Add_theme_support_and_improve_client_configuration branch May 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants