Skip to content

[SDK] Fix MetaMask deeplink parsing #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

[SDK] Fix MetaMask deeplink parsing #6963

merged 1 commit into from
May 6, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 6, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on fixing the parsing of the MetaMask deep link in the thirdweb package, ensuring that the link is correctly formatted based on the wallet being used.

Detailed summary

  • Updated the link generation logic in the DeepLinkConnectUI.tsx file.
  • Changed const link to let link for reassignment.
  • Added a conditional check for props.wallet.id to modify the link format for MetaMask.
  • Ensured that the link is encoded only for non-MetaMask wallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:49pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:49pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:49pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:49pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:49pm

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 2b5da31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 6, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 6, 2025 20:41
@joaquim-verges joaquim-verges requested review from a team as code owners May 6, 2025 20:41
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 218 ms (+184.26% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 363 ms (+112.47% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 94 ms (+2111.52% 🔺) 207 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 23 ms (+948.43% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 128 ms (+945.9% 🔺) 517 ms

@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.03%. Comparing base (9d40b13) to head (2b5da31).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...t/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6963   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57347    +5     
  Branches     3967     3968    +1     
=======================================
+ Hits        31558    31561    +3     
- Misses      25687    25689    +2     
  Partials       97       97
Flag Coverage Δ
packages 55.03% <0.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...t/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx 20.00% <0.00%> (-2.00%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 760b250 into main May 6, 2025
25 of 26 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Fix_MetaMask_deeplink_parsing branch May 6, 2025 23:48
@joaquim-verges joaquim-verges mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges