Skip to content

[SDK] Fix MetaMask deeplink parsing #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

[SDK] Fix MetaMask deeplink parsing #6963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-hats-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix metamask deeplink parsing
7 changes: 6 additions & 1 deletion packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@
onBack?: () => void;
client: ThirdwebClient;
}) => {
const link = encodeURIComponent(window.location.toString());
let link = window.location.toString();
if (props.wallet.id === "io.metamask") {
link = link.replace("https://", "");
} else {
link = encodeURIComponent(link);
}

Check warning on line 33 in packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx#L28-L33 

Added lines #L28 - L33 were not covered by tests
const deeplink = `${props.deepLinkPrefix}${link}?ref=${link}`;
return (
<Container animate="fadein">
Expand Down
Loading