[SDK] Fix hex value handling for smart wallet execution #6974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c878303 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
joaquim-verges
force-pushed
the
_SDK_Fix_hex_value_handling_for_smart_wallet_execution
branch
from
9f09930 to
c878303
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6974 +/- ##
==========================================
- Coverage 55.02% 54.80% -0.23%
==========================================
Files 898 901 +3
Lines 57352 57610 +258
Branches 3969 3958 -11
==========================================
+ Hits 31560 31575 +15
- Misses 25692 25935 +243
Partials 100 100
🚀 New features to boost your workflow:
|
joaquim-verges
deleted the
_SDK_Fix_hex_value_handling_for_smart_wallet_execution
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on handling hex value formats for smart wallet execution and includes adjustments for value calculations specific to hedera chains.
Detailed summary
getNFT1155to setuseIndexertofalse.value / BigInt(10 ** 10)toBigInt(value) / BigInt(10 ** 10)inpackages/thirdweb/src/wallets/smart/lib/calls.ts.prepareBatchExecute.