Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 9, 2025


PR-Codex overview

This PR focuses on refactoring the PayAnalytics component and related functionalities to integrate universal bridge statistics, while removing deprecated code and enhancing the data handling for various analytics components.

Detailed summary

  • Deleted several unused files related to PayAnalytics.
  • Removed NEXT_PUBLIC_PAY_URL constant.
  • Introduced getUniversalBridgeFiltersFromSearchParams function.
  • Added new interfaces for UniversalBridgeStats and UniversalBridgeWalletStats.
  • Updated PayAnalytics to fetch universal bridge data.
  • Refactored PaymentsSuccessRate, TotalVolumePieChart, Payouts, and PayCustomersTable to use new data structures.
  • Enhanced PayAnalyticsFilter to utilize universal bridge filters.
  • Removed deprecated hooks and components.
  • Improved error handling and loading states in various components.

The following files were skipped due to too many changes: pnpm-lock.yaml, apps/dashboard/src/components/pay/PayAnalytics/components/PaymentHistory.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 9, 2025 05:53
@linear
Copy link

linear bot commented May 9, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: f2eca24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 8:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 9, 2025 8:59pm
login ⬜️ Skipped (Inspect) May 9, 2025 8:59pm
thirdweb_playground ⬜️ Skipped (Inspect) May 9, 2025 8:59pm
wallet-ui ⬜️ Skipped (Inspect) May 9, 2025 8:59pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.17 KB (0%) 1.1 s (0%) 181 ms (+171.19% 🔺) 1.3 s
thirdweb (cjs) 193.88 KB (0%) 3.9 s (0%) 352 ms (+31.17% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 60 ms (+542.59% 🔺) 174 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 46 ms (+1754.21% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 85 ms (+549.6% 🔺) 475 ms

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (a68ec74) to head (484fc3d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6988   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         903      903           
  Lines       57934    57934           
  Branches     3970     3968    -2     
=======================================
+ Hits        31632    31636    +4     
+ Misses      26202    26198    -4     
  Partials      100      100           
Flag Coverage Δ
packages 54.60% <ø> (+<0.01%) ⬆️

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const isEmpty =
!props.data ||
props.data.length === 0 ||
props.data.every((x) => x.developerFeeUsdCents === 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tranform it to cents somewhere? remember in usage its USD, not cents

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its transformed to cents in the analytics API to be consistent with the amount field


data = (() => {
if (successType === "fail") {
return data.filter((x) => x.status === "failed");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit: noticed that on an empty dashboard, it shows the bar fully red, with 0 success 0 failed

</div>
);
}
import {} from "@/components/ui/select";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty import

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:31 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4164-migrate-dashboard-analytics branch from 85e9a2d to 478ff96 Compare May 9, 2025 20:32
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:50 Inactive
@gregfromstl gregfromstl merged commit 451594c into main May 10, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4164-migrate-dashboard-analytics branch May 10, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants