-
Notifications
You must be signed in to change notification settings - Fork 621
Feature: Migrate Universal Bridge Analytics #6988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
6c9621d to
becd948
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6988 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 903 903
Lines 57934 57934
Branches 3970 3968 -2
=======================================
+ Hits 31632 31636 +4
+ Misses 26202 26198 -4
Partials 100 100
🚀 New features to boost your workflow:
|
| const isEmpty = | ||
| !props.data || | ||
| props.data.length === 0 || | ||
| props.data.every((x) => x.developerFeeUsdCents === 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you tranform it to cents somewhere? remember in usage its USD, not cents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah its transformed to cents in the analytics API to be consistent with the amount field
|
|
||
| data = (() => { | ||
| if (successType === "fail") { | ||
| return data.filter((x) => x.status === "failed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit: noticed that on an empty dashboard, it shows the bar fully red, with 0 success 0 failed
| </div> | ||
| ); | ||
| } | ||
| import {} from "@/components/ui/select"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty import
85e9a2d to
478ff96
Compare
PR-Codex overview
This PR focuses on refactoring the
PayAnalyticscomponent and related functionalities to integrate universal bridge statistics, while removing deprecated code and enhancing the data handling for various analytics components.Detailed summary
PayAnalytics.NEXT_PUBLIC_PAY_URLconstant.getUniversalBridgeFiltersFromSearchParamsfunction.UniversalBridgeStatsandUniversalBridgeWalletStats.PayAnalyticsto fetch universal bridge data.PaymentsSuccessRate,TotalVolumePieChart,Payouts, andPayCustomersTableto use new data structures.PayAnalyticsFilterto utilize universal bridge filters.