Only set secret key or client ID when not using auth token #6994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
approved these changes
May 9, 2025
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6994 +/- ##
==========================================
- Coverage 54.60% 54.59% -0.01%
==========================================
Files 903 903
Lines 57934 57935 +1
Branches 3968 3970 +2
==========================================
- Hits 31636 31632 -4
- Misses 26198 26202 +4
- Partials 100 101 +1
🚀 New features to boost your workflow:
|
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 9, 2025
This PR modifies the header setting logic in `getClientFetch` to ensure that secret keys and client IDs are only set when not using an auth token. This prevents potential conflicts between different authentication methods by making the header setting logic mutually exclusive.
graphite-app
bot
force-pushed
the
Only_set_secret_key_or_client_ID_when_not_using_auth_token
branch
from
b1e96c0 to
e8b2580
Compare
joaquim-verges
approved these changes
May 9, 2025
This PR modifies the header setting logic in `getClientFetch` to ensure that secret keys and client IDs are only set when not using an auth token. This prevents potential conflicts between different authentication methods by making the header setting logic mutually exclusive.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR modifies the logic in the `fetch.ts` file to ensure that the `x-secret-key` and `x-client-id` headers are only set when not using the authentication token, enhancing security and clarity in header management.
### Detailed summary
- Added an `else` clause to only set `x-secret-key` if not using the auth token.
- Rearranged the condition for setting `x-client-id` to follow the new logic.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
Only_set_secret_key_or_client_ID_when_not_using_auth_token
branch
from
05fd329 to
e739de1
Compare
graphite-app
bot
deleted the
Only_set_secret_key_or_client_ID_when_not_using_auth_token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the header setting logic in
getClientFetchto ensure that secret keys and client IDs are only set when not using an auth token. This prevents potential conflicts between different authentication methods by making the header setting logic mutually exclusive.PR-Codex overview
This PR modifies the logic for setting HTTP headers in the
fetch.tsfile. It ensures that thex-secret-keyandx-client-idheaders are only set when an authentication token is not being used, improving the conditional handling of these headers.Detailed summary
x-secret-keyto only occur if an authentication token is not used.if (clientId)condition to maintain clarity in header setting.