Feature: Add client id to checkout form url #6997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6997 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 903 903
Lines 57934 57934
Branches 3970 3970
=======================================
Hits 31632 31632
Misses 26202 26202
Partials 100 100
🚀 New features to boost your workflow:
|
gregfromstl
force-pushed
the
greg/feat-add-clientId-to-checkout-form
branch
from
c34fcde to
4dd7401
Compare
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
May 10, 2025
gregfromstl
force-pushed
the
greg/feat-add-clientId-to-checkout-form
branch
from
3b3e354 to
b0ae16a
Compare
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `CheckoutLinkForm` component by passing a `client` prop to it and improving its functionality. It also refines the styling and class management using the `cn` utility for better readability and maintainability.
### Detailed summary
- Modified `page.tsx` to create a `client` using `getClientThirdwebClient` and pass it to `CheckoutLinkForm`.
- Changed the `CheckoutLinkForm` function signature to accept a `client` prop.
- Updated multiple instances in `CheckoutLinkForm` to utilize `client.clientId`.
- Replaced static class names with the `cn` utility for dynamic class management in the button and div elements.
- Adjusted the conditional rendering of classes for better readability and performance in the component.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
greg/feat-add-clientId-to-checkout-form
branch
from
b0ae16a to
9634e49
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
CheckoutLinkFormcomponent by allowing it to accept aclientprop for better client management, updates its internal state handling, and improves class name management using thecnutility for conditional styling.Detailed summary
page.tsxto create aclientinstance and pass it toCheckoutLinkForm.CheckoutLinkFormto acceptclientas a prop.CheckoutLinkForm.cnutility for conditional styling.showAdvancedstate.