Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 10, 2025


PR-Codex overview

This PR refactors the checkout functionality into a pay system, updating types, components, and API interactions to accommodate the new payment process.

Detailed summary

  • Renamed CheckoutParams to PayParams.
  • Updated CheckoutEmbed to PayPageEmbed.
  • Modified PaymentHistory to accept teamId.
  • Changed API calls to include teamId.
  • Refactored CheckoutLinkForm to PaymentLinkForm.
  • Updated metadata and routing for payment.
  • Adjusted webhook functions to handle teamId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

gregfromstl and others added 2 commits May 9, 2025 19:16
- Added teamId parameter to all Universal Bridge API calls
- Updated webhook components to pass teamId to API functions
- Fixed client ID references in payment components
- Renamed checkout components to pay components to align with new structure

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@gregfromstl gregfromstl requested review from a team as code owners May 10, 2025 05:03
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

⚠️ No Changeset found

Latest commit: a83e6eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 5:15am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 5:15am
login ⬜️ Skipped (Inspect) May 10, 2025 5:15am
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 5:15am
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 5:15am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 10, 2025
@gregfromstl gregfromstl changed the title Fix: Invalid client ID override [Dashboard] Fix: Invalid client ID override May 10, 2025
@gregfromstl gregfromstl changed the title [Dashboard] Fix: Invalid client ID override [Dashboard] Fix: Use x-client-id + x-team-id for all UB requests May 10, 2025
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label May 10, 2025
Copy link
Contributor Author

Merge activity

  • May 10, 1:04 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (451594c) to head (f69c7e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6999      +/-   ##
==========================================
- Coverage   54.60%   54.59%   -0.01%     
==========================================
  Files         903      903              
  Lines       57934    57935       +1     
  Branches     3968     3970       +2     
==========================================
- Hits        31636    31632       -4     
- Misses      26198    26202       +4     
- Partials      100      101       +1     
Flag Coverage Δ
packages 54.59% <ø> (-0.01%) ⬇️

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…onnect/universal-bridge/webhooks/components/webhooks.client.tsx

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: greg <[email protected]>
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 05:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 05:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 05:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 05:07 Inactive
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 264 ms (+90.02% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 600 ms (+9.16% 🔺) 4.5 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 122 ms (+1407.43% 🔺) 236 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 41 ms (+1242.42% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 137 ms (+549.24% 🔺) 528 ms

@gregfromstl gregfromstl merged commit 282d9f2 into main May 10, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/fix-invalid-client-id-override branch May 10, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants