Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 10, 2025


PR-Codex overview

This PR focuses on improving the user interface and functionality of the payment process in the PaymentLinkForm component, along with adjustments in the layout and behavior of the NetworkSelectors and related components.

Detailed summary

  • Changed alignment from justify-end to justify-start in the universal-bridge page.
  • Added disableTestnets prop to SingleNetworkSelector.
  • Updated URL variable names from checkoutUrl to paymentUrl.
  • Modified success and error messages to reflect payment context.
  • Adjusted spacing in various components for better UI.
  • Enhanced filtering logic in SingleNetworkSelector to exclude testnets when disableTestnets is true.
  • Updated placeholder text in the payment form for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

gregfromstl and others added 3 commits May 9, 2025 19:16
- Added teamId parameter to all Universal Bridge API calls
- Updated webhook components to pass teamId to API functions
- Fixed client ID references in payment components
- Renamed checkout components to pay components to align with new structure

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Add disableTestnets prop to SingleNetworkSelector component
- Apply disableTestnets to payment link form network selector

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@gregfromstl gregfromstl requested review from a team as code owners May 10, 2025 05:24
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

⚠️ No Changeset found

Latest commit: cc881a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 5:49am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 5:49am
login ⬜️ Skipped (Inspect) May 10, 2025 5:49am
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 5:49am
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 5:49am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl changed the title [Dashboard] Feature: Disable testnets in Pay form [Dashboard] Feature: Disable testnets in Payment Link form May 10, 2025
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 10, 2025
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label May 10, 2025
Copy link
Contributor Author

Merge activity

  • May 10, 1:25 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (282d9f2) to head (dd0fb7e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7000   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files         903      903           
  Lines       57935    57935           
  Branches     3970     3970           
=======================================
  Hits        31632    31632           
  Misses      26202    26202           
  Partials      101      101           
Flag Coverage Δ
packages 54.59% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 264 ms (+162.41% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 557 ms (+33.35% 🔺) 4.5 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 106 ms (+758.32% 🔺) 219 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 44 ms (+1832.16% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 98 ms (+509.58% 🔺) 489 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 05:29 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 05:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 05:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 05:29 Inactive
This restores the disableTestnets prop for the SingleNetworkSelector in the PaymentLinkForm component, which was mistakenly removed. Also removed unnecessary login redirect from pay page to allow anonymous payments.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@gregfromstl gregfromstl force-pushed the greg/fix-invalid-client-id-override branch from 2b133c1 to fd0aa2d Compare May 10, 2025 05:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 05:33 Inactive
- Change justify-end to justify-start in universal-bridge page for better analytics filter placement
- Reduce spacing in payment form advanced options for more compact display
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 05:40 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 05:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 05:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 05:40 Inactive
@gregfromstl gregfromstl merged commit 8b50779 into main May 10, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/fix-invalid-client-id-override branch May 10, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants