Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 10, 2025

Fixed issue with the disableTestnets filter in SingleNetworkSelector to properly filter out testnets regardless of chainIds being provided.

🤖 Generated with Claude Code


PR-Codex overview

This PR refactors the logic in the chainsToShow computation within the NetworkSelectors.tsx component to improve readability and efficiency by using a chains variable that is filtered based on props.disableTestnets and props.chainIds.

Detailed summary

  • Introduced a chains variable to hold allChains.
  • Added a filter for chains to exclude testnets if props.disableTestnets is true.
  • Simplified the filtering of chains based on props.chainIds using a Set.
  • Removed redundant filtering logic that combined testnet and chain ID checks into a single return statement.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Fixed issue with the disableTestnets filter in SingleNetworkSelector to properly filter out testnets regardless of chainIds being provided.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@gregfromstl gregfromstl requested review from a team as code owners May 10, 2025 06:04
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

⚠️ No Changeset found

Latest commit: 6877c6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented May 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 10, 2025 6:04am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 6:04am
login ⬜️ Skipped (Inspect) May 10, 2025 6:04am
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 6:04am
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 6:04am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 10, 2025
@gregfromstl gregfromstl added merge-queue Adds the pull request to Graphite's merge queue. and removed Dashboard Involves changes to the Dashboard. labels May 10, 2025
Copy link
Contributor Author

Merge activity

  • May 10, 2:04 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@gregfromstl gregfromstl merged commit 7ede361 into main May 10, 2025
19 of 20 checks passed
@gregfromstl gregfromstl deleted the greg/fix-testnet-filter branch May 10, 2025 06:05
@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (8b50779) to head (6877c6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7001   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files         903      903           
  Lines       57935    57935           
  Branches     3970     3970           
=======================================
  Hits        31632    31632           
  Misses      26202    26202           
  Partials      101      101           
Flag Coverage Δ
packages 54.59% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 195 ms (+106.08% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 405 ms (+18.14% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 88 ms (+870.66% 🔺) 202 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 33 ms (+1385.07% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 112 ms (+458% 🔺) 503 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants