-
Notifications
You must be signed in to change notification settings - Fork 621
Fix testnet filtering in NetworkSelectors #7001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed issue with the disableTestnets filter in SingleNetworkSelector to properly filter out testnets regardless of chainIds being provided. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7001 +/- ##
=======================================
Coverage 54.59% 54.59%
=======================================
Files 903 903
Lines 57935 57935
Branches 3970 3970
=======================================
Hits 31632 31632
Misses 26202 26202
Partials 101 101
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Fixed issue with the disableTestnets filter in SingleNetworkSelector to properly filter out testnets regardless of chainIds being provided.
🤖 Generated with Claude Code
PR-Codex overview
This PR refactors the logic in the
chainsToShowcomputation within theNetworkSelectors.tsxcomponent to improve readability and efficiency by using achainsvariable that is filtered based onprops.disableTestnetsandprops.chainIds.Detailed summary
chainsvariable to holdallChains.chainsto exclude testnets ifprops.disableTestnetsis true.chainsbased onprops.chainIdsusing aSet.