Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 10, 2025


PR-Codex overview

This PR focuses on enhancing EIP-5792 support within the thirdweb library, introducing new hooks for sending and confirming calls, and updating existing functionalities for better wallet capabilities management.

Detailed summary

  • Removed useCallsStatus.
  • Added useSendAndConfirmCalls and useWaitForCallsReceipt hooks.
  • Updated sendCalls to return an object with id, client, chain, and wallet.
  • Changed getCallsStatus to use id instead of bundleId.
  • Enhanced wallet capabilities management for EIP-5792.
  • Updated various tests to reflect changes in parameters and return types.
  • Improved error handling for unsupported wallet methods.

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/eip5792/send-calls.ts, apps/playground-web/src/components/account-abstraction/5792-send-calls.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:26am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:26am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:26am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:26am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:26am

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

🦋 Changeset detected

Latest commit: 6bb93b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels May 10, 2025
@joaquim-verges joaquim-verges changed the title Add EIP-5792 wallet capabilities support Improve EIP-5792 wallet capabilities support May 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Improve EIP-5792 wallet capabilities support [SDK] Improve EIP-5792 wallet capabilities support May 10, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 10, 2025 12:08
@joaquim-verges joaquim-verges requested review from a team as code owners May 10, 2025 12:08
@joaquim-verges joaquim-verges force-pushed the Add_EIP-5792_wallet_capabilities_support branch from 44986f3 to 2951f8f Compare May 10, 2025 12:09
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 242 ms (+103.85% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 458 ms (+12.84% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 108 ms (+1274.78% 🔺) 222 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 35 ms (+362.42% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (-0.08% 🔽) 391 ms (-0.08% 🔽) 73 ms (+262.14% 🔺) 464 ms

@joaquim-verges joaquim-verges force-pushed the Add_EIP-5792_wallet_capabilities_support branch from dadce96 to 8520427 Compare May 12, 2025 05:19
@joaquim-verges joaquim-verges force-pushed the Add_EIP-5792_wallet_capabilities_support branch from 8520427 to 7834169 Compare May 12, 2025 07:30
@joaquim-verges joaquim-verges force-pushed the Add_EIP-5792_wallet_capabilities_support branch from 7834169 to 7fa79e1 Compare May 12, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants