Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 10, 2025


PR-Codex overview

This PR focuses on modifying how transaction values are handled in the engineAccount within the thirdweb wallet. It ensures that the transaction value is correctly assigned and is always required.

Detailed summary

  • In packages/thirdweb/src/wallets/engine/index.ts:
    • Changed the assignment of value in the transaction data from toHex(transaction.value ?? 0n) to transaction.value ?? 0n.
    • Added value: transaction.value to txOverrides.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:12pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:12pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:12pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:12pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:12pm

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

🦋 Changeset detected

Latest commit: e0c3f53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 10, 2025
@joaquim-verges joaquim-verges changed the title Handle tx with value on engineAccount [SDK] Handle tx with value on engineAccount May 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 192 ms (+75.81% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 392 ms (-0.53% 🔽) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 73 ms (+969.65% 🔺) 187 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 32 ms (+551.04% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 79 ms (+274.28% 🔺) 470 ms

@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.60%. Comparing base (7ede361) to head (e0c3f53).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/engine/index.ts 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7004   +/-   ##
=======================================
  Coverage   54.59%   54.60%           
=======================================
  Files         903      903           
  Lines       57935    57936    +1     
  Branches     3970     3973    +3     
=======================================
+ Hits        31632    31637    +5     
+ Misses      26202    26198    -4     
  Partials      101      101           
Flag Coverage Δ
packages 54.60% <0.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/engine/index.ts 12.40% <0.00%> (-0.10%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 6f1d4b1 into main May 10, 2025
25 of 26 checks passed
@joaquim-verges joaquim-verges deleted the Handle_tx_with_value_on_engineAccount branch May 10, 2025 13:13
@joaquim-verges joaquim-verges mentioned this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants