Skip to content

[SDK] Fix: Automatically trigger login for connected wallets whe… #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2025
Merged

[SDK] Fix: Automatically trigger login for connected wallets whe… #7009

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
322a014
[Thirdweb] Fix: Automatically trigger login for connected wallets whe…
gregfromstl May 11, 2025
c2acfd1
fix: only trigger SIWE auto sign in for IAW
gregfromstl May 11, 2025
3edf931
feat: auto-login when connecting via url
gregfromstl May 11, 2025
da3e776
fix: include full useSiweAuth return value
gregfromstl May 11, 2025
a3a9e63
lint
gregfromstl May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/every-sides-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Automatically trigger SIWE sign in when a wallet is connected
24 changes: 24 additions & 0 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { LockIcon } from "./icons/LockIcon.js";
import { useConnectLocale } from "./locale/getConnectLocale.js";
import type { ConnectLocale } from "./locale/types.js";
import { SignatureScreen } from "./screens/SignatureScreen.js";
import { useAdminWallet } from "src/exports/react.native.js";

const TW_CONNECT_WALLET = "tw-connect-wallet";

Expand Down Expand Up @@ -400,6 +401,7 @@ function ConnectButtonInner(
) {
const activeWallet = useActiveWallet();
const activeAccount = useActiveAccount();
const adminWallet = useAdminWallet();
const siweAuth = useSiweAuth(activeWallet, activeAccount, props.auth);
const [showSignatureModal, setShowSignatureModal] = useState(false);

Expand All @@ -410,6 +412,28 @@ function ConnectButtonInner(
}
}, [activeAccount]);

// if an IAW wallet is connected and auth is required, trigger a login attempt automatically
useEffect(() => {
const isIAW = activeWallet?.id === "inApp" || adminWallet?.id === "inApp";
Copy link
Member

@joaquim-verges joaquim-verges May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a helper for this? That handles smart and ecosystem too

if (
activeAccount &&
Copy link
Member

@joaquim-verges joaquim-verges May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only do this for in app wallets. Coz on mobile you really need an explicit click otherwise things break quickly.

siweAuth.requiresAuth &&
!siweAuth.isLoggedIn &&
!siweAuth.isLoggingIn &&
isIAW
) {
siweAuth.doLogin();
}
}, [
activeAccount,
siweAuth.requiresAuth,
siweAuth.doLogin,
siweAuth.isLoggedIn,
siweAuth.isLoggingIn,
activeWallet,
adminWallet,
]);

const theme = props.theme || "dark";
const connectionStatus = useActiveWalletConnectionStatus();
const locale = props.connectLocale;
Expand Down
Loading