Skip to content

Fix: Catch siwe doLogin errors #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 11, 2025
Merged

Fix: Catch siwe doLogin errors #7012

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
322a014
[Thirdweb] Fix: Automatically trigger login for connected wallets whe…
gregfromstl May 11, 2025
c2acfd1
fix: only trigger SIWE auto sign in for IAW
gregfromstl May 11, 2025
3edf931
feat: auto-login when connecting via url
gregfromstl May 11, 2025
da3e776
fix: include full useSiweAuth return value
gregfromstl May 11, 2025
a3a9e63
lint
gregfromstl May 11, 2025
5b07c95
Merge branch 'main' into greg/tool-4452-telegram-redirect-login-on-io…
gregfromstl May 11, 2025
1894888
fix: auto-login on autoconnect of IAW in all cases
gregfromstl May 11, 2025
bab2088
lint
gregfromstl May 11, 2025
62c2414
fix: catch siwe doLogin
gregfromstl May 11, 2025
052685f
Merge branch 'main' into greg/tool-4452-telegram-redirect-login-on-io…
gregfromstl May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/thirdweb/src/wallets/connection/autoConnectCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ const _autoConnectCore = async ({
!props.siweAuth?.isLoggedIn &&
!props.siweAuth?.isLoggingIn
) {
await props.siweAuth?.doLogin();
await props.siweAuth?.doLogin().catch((err) => {
console.warn("Error signing in with SIWE:", err.message);
});
}
manager.isAutoConnecting.setValue(false);
return autoConnected; // useQuery needs a return value
Expand Down
Loading