Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 12, 2025


PR-Codex overview

This PR focuses on exposing the inMemoryStorage for the inAppWallet backend, allowing for the storage of authentication tokens. It also includes tests for the inAppWallet using this new storage mechanism.

Detailed summary

  • Added export of inMemoryStorage in packages/thirdweb/src/exports/storage.ts.
  • Implemented inMemoryStorage in packages/thirdweb/src/utils/storage/inMemoryStorage.ts with methods: getItem, setItem, and removeItem.
  • Updated documentation in packages/thirdweb/src/wallets/in-app/web/in-app.ts to include usage of inMemoryStorage.
  • Created a test for inAppWallet in packages/thirdweb/src/wallets/in-app/web/lib/in-app-backend.test.ts that verifies signing a message with backend strategy using inMemoryStorage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:31am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:31am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:31am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:31am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 10:31am

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 8339910

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 232 ms (+244.47% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 382 ms (+48.62% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 100 ms (+1580.61% 🔺) 214 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 46 ms (+1788.47% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 94 ms (+690.26% 🔺) 485 ms

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (e8ec54e) to head (8339910).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ages/thirdweb/src/utils/storage/inMemoryStorage.ts 75.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7016      +/-   ##
==========================================
+ Coverage   54.71%   54.90%   +0.18%     
==========================================
  Files         904      909       +5     
  Lines       57991    58374     +383     
  Branches     4004     4034      +30     
==========================================
+ Hits        31731    32051     +320     
- Misses      26155    26218      +63     
  Partials      105      105              
Flag Coverage Δ
packages 54.90% <75.00%> (+0.18%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/in-app/web/in-app.ts 100.00% <ø> (+43.75%) ⬆️
...ages/thirdweb/src/utils/storage/inMemoryStorage.ts 75.00% <75.00%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges changed the title Expose inMemoryStorage for inAppWallet backend usage [SDK] Expose inMemoryStorage for inAppWallet backend usage May 12, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 12, 2025 10:19
@joaquim-verges joaquim-verges requested review from a team as code owners May 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants