-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Expose inMemoryStorage for inAppWallet backend usage #7016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Expose inMemoryStorage for inAppWallet backend usage #7016
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8339910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7016 +/- ##
==========================================
+ Coverage 54.71% 54.90% +0.18%
==========================================
Files 904 909 +5
Lines 57991 58374 +383
Branches 4004 4034 +30
==========================================
+ Hits 31731 32051 +320
- Misses 26155 26218 +63
Partials 105 105
🚀 New features to boost your workflow:
|
71cba4b to
8339910
Compare

PR-Codex overview
This PR focuses on exposing the
inMemoryStoragefor theinAppWalletbackend, allowing for the storage of authentication tokens. It also includes tests for theinAppWalletusing this new storage mechanism.Detailed summary
inMemoryStorageinpackages/thirdweb/src/exports/storage.ts.inMemoryStorageinpackages/thirdweb/src/utils/storage/inMemoryStorage.tswith methods:getItem,setItem, andremoveItem.packages/thirdweb/src/wallets/in-app/web/in-app.tsto include usage ofinMemoryStorage.inAppWalletinpackages/thirdweb/src/wallets/in-app/web/lib/in-app-backend.test.tsthat verifies signing a message with backend strategy usinginMemoryStorage.