Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 13, 2025

Fixes TOOL-4476

@vercel
Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 0:12am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 0:12am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 0:12am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 0:12am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 0:12am

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 8b69224

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 13, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented May 13, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 311 ms (+29.62% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 987 ms (+7.36% 🔺) 4.9 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 71 ms (+239.94% 🔺) 185 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 35 ms (+484.59% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 45 ms (+2.76% 🔺) 435 ms

@joaquim-verges joaquim-verges merged commit b15c3c0 into main May 13, 2025
23 checks passed
@joaquim-verges joaquim-verges deleted the Add_contract_availability_documentation_to_ERC_methods branch May 13, 2025 00:47
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (1985de8) to head (8b69224).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7033      +/-   ##
==========================================
- Coverage   54.90%   54.89%   -0.01%     
==========================================
  Files         909      909              
  Lines       58374    58374              
  Branches     4034     4035       +1     
==========================================
- Hits        32051    32046       -5     
- Misses      26218    26223       +5     
  Partials      105      105              
Flag Coverage Δ
packages 54.89% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...dweb/src/extensions/erc1155/drops/read/canClaim.ts 100.00% <ø> (ø)
...ions/erc1155/drops/read/getActiveClaimCondition.ts 80.00% <ø> (ø)
...xtensions/erc1155/drops/read/getClaimConditions.ts 85.45% <ø> (ø)
...dweb/src/extensions/erc1155/drops/write/claimTo.ts 78.78% <ø> (ø)
...sions/erc1155/drops/write/resetClaimEligibility.ts 89.83% <ø> (ø)
...tensions/erc1155/drops/write/setClaimConditions.ts 78.78% <ø> (ø)
.../thirdweb/src/extensions/erc1155/write/lazyMint.ts 96.55% <ø> (ø)
...extensions/erc1155/write/mintAdditionalSupplyTo.ts 100.00% <ø> (ø)
...sions/erc1155/write/mintAdditionalSupplyToBatch.ts 98.03% <ø> (ø)
...es/thirdweb/src/extensions/erc1155/write/mintTo.ts 100.00% <ø> (ø)
... and 24 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants