Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 14, 2025


PR-Codex overview

This PR introduces new metadata patterns for handling eoa:read and eoa:create types in the vault.client.ts file, specifically relating to project and team identifiers.

Detailed summary

  • Added a new eoa:read type with metadataPatterns for projectId, teamId, and type.
  • Added a new eoa:create type with requiredMetadataPatterns for projectId, teamId, and type.
  • Both types use the props.project.id and props.project.teamId for their respective patterns.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:15am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 14, 2025 10:15am
login ⬜️ Skipped (Inspect) May 14, 2025 10:15am
thirdweb_playground ⬜️ Skipped (Inspect) May 14, 2025 10:15am
wallet-ui ⬜️ Skipped (Inspect) May 14, 2025 10:15am

@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 10:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 10:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 10:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 10:08 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 29e9fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review May 14, 2025 10:09
@joaquim-verges joaquim-verges requested review from a team as code owners May 14, 2025 10:09
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 151 ms (+107.1% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 322 ms (+22.93% 🔺) 4.2 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 71 ms (+927.56% 🔺) 185 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 24 ms (+1343.91% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 84 ms (+660.57% 🔺) 474 ms

@joaquim-verges joaquim-verges merged commit 1191d5d into main May 14, 2025
23 checks passed
@joaquim-verges joaquim-verges deleted the _Engine_Add_EOA_read/create_permissions_for_server_wallets branch May 14, 2025 10:32
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (1c31a1e) to head (29e9fa2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7043      +/-   ##
==========================================
+ Coverage   54.89%   55.51%   +0.61%     
==========================================
  Files         909      909              
  Lines       58396    58402       +6     
  Branches     4035     4071      +36     
==========================================
+ Hits        32056    32419     +363     
+ Misses      26235    25878     -357     
  Partials      105      105              
Flag Coverage Δ
packages 55.51% <ø> (+0.61%) ⬆️

see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants