Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented May 14, 2025

CORE-0000


PR-Codex overview

This PR updates the preferredProvider options in the detailsModal of the connectbutton component to include a new payment provider.

Detailed summary

  • Updated preferredProvider options in payOptions from:
    • "STRIPE" | "KADO" | "TRANSAK"
    • To: "STRIPE" | "TRANSAK" | "COINBASE"
  • Removed "KADO" and added "COINBASE" as a payment option.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners May 14, 2025 17:32
@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 9f1ca54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 5:46pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 14, 2025 5:46pm
thirdweb_playground ⬜️ Skipped (Inspect) May 14, 2025 5:46pm
thirdweb-www ⬜️ Skipped (Inspect) May 14, 2025 5:46pm
wallet-ui ⬜️ Skipped (Inspect) May 14, 2025 5:46pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (7df81b7) to head (9f1ca54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7048   +/-   ##
=======================================
  Coverage   55.51%   55.51%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4071     4071           
=======================================
  Hits        32419    32419           
  Misses      25878    25878           
  Partials      105      105           
Flag Coverage Δ
packages 55.51% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 176 ms (+189.03% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 347 ms (+31.99% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 64 ms (+1235.29% 🔺) 178 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 33 ms (+2251.7% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 65 ms (+390.27% 🔺) 456 ms

@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
Copy link
Member Author

saminacodes commented May 14, 2025

Merge activity

CORE-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `preferredProvider` options in the `detailsModal` configuration for the `connectbutton` component, enhancing payment provider flexibility.

### Detailed summary
- Modified `preferredProvider` options in `detailsModal`:
  - Removed `"KADO"`
  - Added `"COINBASE"`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the saminacodes-patch-1 branch from a7a8480 to 9f1ca54 Compare May 14, 2025 17:44
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 17:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 17:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 17:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 17:44 Inactive
@graphite-app graphite-app bot merged commit 9f1ca54 into main May 14, 2025
22 checks passed
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
@graphite-app graphite-app bot deleted the saminacodes-patch-1 branch May 14, 2025 17:47
@vercel vercel bot temporarily deployed to Production – login May 14, 2025 17:47 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 14, 2025 17:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www May 14, 2025 17:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 14, 2025 17:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants