Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented May 14, 2025


PR-Codex overview

This PR focuses on enhancing the documentation and user guidance related to the thirdweb Engine, including updates to FAQs, migration guides, and onramp provider information, as well as adding images for better visual support.

Detailed summary

  • Added new section for Onramp Providers in sidebar.tsx.
  • Updated Engine FAQs with pricing details and transaction fees.
  • Revised migration guide in page.mdx for clarity and added a callout about wallet migration.
  • Expanded pay/faqs with additional details on Universal Bridge and KYC requirements.
  • Increased supported countries for Buy With Fiat.
  • Included images for Create Vault and Send Test Transaction in the get-started guide.
  • Detailed provider fees and regions for onramp providers in onramp-providers documentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners May 14, 2025 21:24
@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: ae7407d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 11:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 14, 2025 11:00pm
thirdweb_playground ⬜️ Skipped (Inspect) May 14, 2025 11:00pm
thirdweb-www ⬜️ Skipped (Inspect) May 14, 2025 11:00pm
wallet-ui ⬜️ Skipped (Inspect) May 14, 2025 11:00pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (a443b30) to head (ae7407d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7049   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4070     4070           
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:30 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 169 ms (+154.75% 🔺) 1.3 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 367 ms (+42.33% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 59 ms (+1089.88% 🔺) 173 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 14 ms (+262.75% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 71 ms (+366.44% 🔺) 461 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 21:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:51 Inactive
@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
Copy link
Member Author

saminacodes commented May 14, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the documentation and user guidance for the `thirdweb` platform, specifically around the Engine v3 features, onramp providers, and pricing details. It introduces new FAQs, clarifies migration steps, and adds visual content.

### Detailed summary
- Added new section for "Onramp Providers" in `sidebar.tsx`.
- Updated Engine FAQs in `page.mdx` with pricing and transaction details.
- Revised migration guide in `page.mdx` with clearer instructions and a callout for wallet migration.
- Enhanced `faqs/page.mdx` with additional questions about Universal Bridge and supported payment methods.
- Updated "Buy With Fiat" availability to 160+ countries.
- Included images for creating a vault and sending transactions in the `get-started/page.mdx`.
- Revised onramp providers section to clarify provider preferences and fees in `onramp-providers/page.mdx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 22:53 Inactive
@graphite-app graphite-app bot merged commit ae7407d into main May 14, 2025
23 checks passed
@graphite-app graphite-app bot deleted the misc-changes branch May 14, 2025 23:01
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 14, 2025 23:01 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 14, 2025 23:01 Inactive
@vercel vercel bot temporarily deployed to Production – login May 14, 2025 23:01 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www May 14, 2025 23:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants