Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 15, 2025


PR-Codex overview

This PR focuses on removing the ChangeBadge component from various files and simplifying the logic related to trends in the Payouts, TotalPayVolume, and PayNewCustomers components. It also renames a label for clarity.

Detailed summary

  • Removed ChangeBadge component from common.tsx.
  • Simplified useMemo in Payouts to exclude trend calculation.
  • Removed trend-related logic in TotalPayVolume.
  • Removed trend-related logic in PayNewCustomers.
  • Renamed label from "Customers" to "New Customers" in PayNewCustomers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 15, 2025 18:46
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: 5425e02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 7:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 15, 2025 7:05pm
login ⬜️ Skipped (Inspect) May 15, 2025 7:05pm
thirdweb_playground ⬜️ Skipped (Inspect) May 15, 2025 7:05pm
wallet-ui ⬜️ Skipped (Inspect) May 15, 2025 7:05pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 15, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (0eff648) to head (5425e02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7059   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4070     4070           
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 148 ms (+29.25% 🔺) 1.3 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 426 ms (+3.63% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 69 ms (+924.48% 🔺) 182 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 11 ms (+301.87% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 60 ms (+200.87% 🔺) 450 ms

@gregfromstl gregfromstl force-pushed the greg/fix-analytics-ui branch from 81957ee to 2212dca Compare May 15, 2025 18:55
@vercel vercel bot temporarily deployed to Preview – login May 15, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 15, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 15, 2025 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 15, 2025 18:55 Inactive
@gregfromstl gregfromstl force-pushed the greg/fix-analytics-ui branch from 2212dca to 5425e02 Compare May 15, 2025 18:57
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 15, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 15, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 15, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 15, 2025 18:57 Inactive
@gregfromstl gregfromstl merged commit ba52e68 into main May 15, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/fix-analytics-ui branch May 15, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants