[SDK] Refactor: Switch PayEmbed Swap Quotes to use UB #7062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the behavior of buyWithCrypto to use the Universal Bridge service instead of the legacy API - Updates getQuote and getTransfer implementation to use Bridge.Buy and Bridge.Sell - Adds a new Transfer module to the Bridge namespace for token transfers - Removes the legacy API endpoints from definitions.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Adds new Transfer module for direct token transfers - Implements prepare function for getting transfer quotes and transactions - Adds tests for the Transfer module 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2c33488 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (22.78%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7062 +/- ##
==========================================
- Coverage 55.50% 55.36% -0.15%
==========================================
Files 909 910 +1
Lines 58402 58682 +280
Branches 4070 4087 +17
==========================================
+ Hits 32415 32488 +73
- Misses 25882 26088 +206
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a new
Transfermodule for direct token transfers within thethirdwebSDK, enhancing the bridge functionality. It includes new methods for preparing transfer quotes and adds testing for the transfer functionality.Detailed summary
Transferexport inpackages/thirdweb/src/bridge/index.ts.Transfermodule with thepreparemethod for token transfers.BuyandSellmodules to includeamountin transaction requests.getBuyWithCryptoTransferandgetBuyWithCryptoQuoteto utilize the newTransfermodule.Transferfunctionality inpackages/thirdweb/src/bridge/Transfer.test.ts.packages/thirdweb/src/pay/utils/definitions.ts.getTransfer.tsandgetQuote.tsto reflect changes in the transfer logic.