[SDK] Fix stray keccak256 reference #7089

joaquim-verges · 2025-05-20T02:00:36Z

Summary

remove unused keccak256 import
clean up unused statement in resolve-l2-name

Testing

pnpm test (fails: EHOSTUNREACH)

PR-Codex overview

This PR removes an unused import of keccak256 from the resolve-l2-name.ts file, streamlining the code.

Detailed summary

Removed unused import of keccak256 from viem.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Chores
- Removed unused code and imports to improve code cleanliness.

changeset-bot · 2025-05-20T02:00:40Z

⚠️ No Changeset found

Latest commit: 6bad544

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-05-20T02:00:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 7:07pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 7:07pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 7:07pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 7:07pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 7:07pm

graphite-app · 2025-05-20T02:00:45Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2025-05-20T02:06:27Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	56.57 KB (0%)	1.2 s (0%)	216 ms (+97.78% 🔺)	1.4 s
thirdweb (cjs)	309.52 KB (0%)	6.2 s (0%)	830 ms (+3.29% 🔺)	7.1 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	67 ms (+768.77% 🔺)	181 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	14 ms (+302.67% 🔺)	24 ms
thirdweb/react (minimal + tree-shaking)	19.5 KB (0%)	390 ms (0%)	42 ms (+117.92% 🔺)	432 ms

codecov · 2025-05-20T02:30:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (6104401) to head (dd3fdb1).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7089      +/-   ##
==========================================
- Coverage   55.81%   55.80%   -0.01%     
==========================================
  Files         900      900              
  Lines       57848    57846       -2     
  Branches     4067     4066       -1     
==========================================
- Hits        32288    32283       -5     
- Misses      25454    25459       +5     
+ Partials      106      104       -2

Flag	Coverage Δ
packages	`55.80% <ø> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
...ges/thirdweb/src/extensions/ens/resolve-l2-name.ts	`88.52% <ø> (-0.37%)`	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-05-20T18:10:37Z

Merge activity

May 20, 6:10 PM UTC: jnsdls added this pull request to the Graphite merge queue.
May 20, 6:18 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Lint Packages').

## Summary - remove unused `keccak256` import - clean up unused statement in `resolve-l2-name` ## Testing - `pnpm test` *(fails: EHOSTUNREACH)*  --- ## PR-Codex overview This PR removes an unused import of `keccak256` from the `resolve-l2-name.ts` file, streamlining the code by eliminating unnecessary references. ### Detailed summary - Removed the unused import of `keccak256` from the file `packages/thirdweb/src/extensions/ens/resolve-l2-name.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

coderabbitai · 2025-05-20T18:11:14Z

Walkthrough

The changes remove an unused import of keccak256 from the "viem" package and delete a redundant reference to keccak256 within the convertReverseNodeToBytes function in the ENS extension module. No exported or public interfaces were altered, and no functional logic was changed.

Changes

File(s)	Change Summary
packages/thirdweb/src/extensions/ens/resolve-l2-name.ts	Removed unused `keccak256` import and redundant reference inside a function.

Poem

A hop and a skip, I clear the code,
Unused imports off the road.
Cleaner now, my warren shines,
No stray hashes in the lines.
With every sweep, I leap with glee,
For tidy code is joy to me! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e7c6043 and 6bad544.

📒 Files selected for processing (1)

packages/thirdweb/src/extensions/ens/resolve-l2-name.ts (0 hunks)

💤 Files with no reviewable changes (1)

packages/thirdweb/src/extensions/ens/resolve-l2-name.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Summary - remove unused `keccak256` import - clean up unused statement in `resolve-l2-name` ## Testing - `pnpm test` *(fails: EHOSTUNREACH)*  --- ## PR-Codex overview This PR focuses on removing an unused import of the `keccak256` function from the `resolve-l2-name.ts` file, which helps in cleaning up the code and improving readability. ### Detailed summary - Removed the import statement for `keccak256` from `viem` in `packages/thirdweb/src/extensions/ens/resolve-l2-name.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **Chores** - Removed unused code and imports to improve code cleanliness.

## Summary - remove unused `keccak256` import - clean up unused statement in `resolve-l2-name` ## Testing - `pnpm test` *(fails: EHOSTUNREACH)*  --- ## PR-Codex overview This PR removes an unused import of `keccak256` from the `resolve-l2-name.ts` file, streamlining the code. ### Detailed summary - Removed the unused import of `keccak256` from the file `packages/thirdweb/src/extensions/ens/resolve-l2-name.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **Chores** - Removed unused code and imports to improve code cleanliness.

joaquim-verges requested review from a team as code owners May 20, 2025 02:00

joaquim-verges added the codex label May 20, 2025 — with ChatGPT Codex Connector

github-actions bot assigned joaquim-verges May 20, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 20, 2025

vercel bot deployed to Preview – login May 20, 2025 02:02 View deployment

vercel bot deployed to Preview – wallet-ui May 20, 2025 02:03 View deployment

vercel bot deployed to Preview – thirdweb_playground May 20, 2025 02:03 View deployment

vercel bot deployed to Preview – thirdweb-www May 20, 2025 02:08 View deployment

vercel bot deployed to Preview – docs-v2 May 20, 2025 02:11 View deployment

joaquim-verges changed the title ~~Fix stray keccak256 reference~~ [SDK] Fix stray keccak256 reference May 20, 2025

vercel bot deployed to Preview – login May 20, 2025 02:29 View deployment

vercel bot deployed to Preview – wallet-ui May 20, 2025 02:29 View deployment

vercel bot deployed to Preview – thirdweb_playground May 20, 2025 02:30 View deployment

vercel bot deployed to Preview – thirdweb-www May 20, 2025 02:32 View deployment

vercel bot deployed to Preview – docs-v2 May 20, 2025 02:34 View deployment

jnsdls approved these changes May 20, 2025

View reviewed changes

graphite-app bot force-pushed the codex/find-and-fix-a-bug-in-codebase branch from ea3588a to c3d0e1a Compare May 20, 2025 18:11

vercel bot deployed to Preview – thirdweb_playground May 20, 2025 18:11 View deployment

vercel bot deployed to Preview – wallet-ui May 20, 2025 18:11 View deployment

vercel bot deployed to Preview – login May 20, 2025 18:13 View deployment

graphite-app bot force-pushed the codex/find-and-fix-a-bug-in-codebase branch from c3d0e1a to e7c6043 Compare May 20, 2025 18:13

graphite-app bot force-pushed the codex/find-and-fix-a-bug-in-codebase branch from e7c6043 to 6bad544 Compare May 20, 2025 18:15

vercel bot deployed to Preview – wallet-ui May 20, 2025 18:21 View deployment

vercel bot deployed to Preview – thirdweb_playground May 20, 2025 18:21 View deployment

vercel bot deployed to Preview – login May 20, 2025 18:23 View deployment

vercel bot deployed to Preview – thirdweb-www May 20, 2025 18:26 View deployment

vercel bot deployed to Preview – docs-v2 May 20, 2025 18:27 View deployment

Merge branch 'main' into codex/find-and-fix-a-bug-in-codebase

dd3fdb1

vercel bot deployed to Preview – wallet-ui May 20, 2025 18:57 View deployment

vercel bot deployed to Preview – thirdweb_playground May 20, 2025 18:58 View deployment

vercel bot deployed to Preview – login May 20, 2025 18:59 View deployment

vercel bot deployed to Preview – thirdweb-www May 20, 2025 19:01 View deployment

vercel bot deployed to Preview – docs-v2 May 20, 2025 19:07 View deployment

joaquim-verges merged commit d2098ad into main May 20, 2025
23 checks passed

joaquim-verges deleted the codex/find-and-fix-a-bug-in-codebase branch May 20, 2025 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix stray keccak256 reference #7089

[SDK] Fix stray keccak256 reference #7089

Uh oh!

joaquim-verges commented May 20, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented May 20, 2025 •

edited

Loading

Uh oh!

vercel bot commented May 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 20, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Fix stray keccak256 reference #7089

[SDK] Fix stray keccak256 reference #7089

Uh oh!

Conversation

joaquim-verges commented May 20, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented May 20, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

coderabbitai bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joaquim-verges commented May 20, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented May 20, 2025 •

edited

Loading

vercel bot commented May 20, 2025 •

edited

Loading

github-actions bot commented May 20, 2025 •

edited

Loading

codecov bot commented May 20, 2025 •

edited

Loading

graphite-app bot commented May 20, 2025 •

edited

Loading

coderabbitai bot commented May 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)