-
Notifications
You must be signed in to change notification settings - Fork 621
fixing code snippets #7094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing code snippets #7094
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| const sdkExample = () => `\ | ||
| import { createThirdwebClient, sendTransaction, getContract, Engine } from "thirdweb"; | ||
| import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please get these on 1 line? reads better in the docs that way, otherwise there's a wall of imports first
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7094 +/- ##
=======================================
Coverage 55.81% 55.81%
=======================================
Files 900 900
Lines 57848 57848
Branches 4077 4077
=======================================
Hits 32286 32286
Misses 25457 25457
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
|
|
||
| const sdkExample = () => `\ | ||
| import { createThirdwebClient, sendTransaction, getContract, Engine } from "thirdweb"; | ||
| import {createThirdwebClient, sendTransaction, getContract, Engine} from "thirdweb"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace :)
fixing the code snippets for engine cloud docs
PR-Codex overview
This PR updates the import path for the
claimTofunction fromthirdweb/extensions/1155tothirdweb/extensions/erc1155and modifies a variable used in a console log statement to correctly reflect the transaction hash.Detailed summary
claimTofromthirdweb/extensions/1155tothirdweb/extensions/erc1155.txHashinstead ofresult.transactionHash.