-
Notifications
You must be signed in to change notification settings - Fork 621
Version Packages #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7105
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis update removes a changeset file documenting a previous SIWE authentication fix, updates changelogs for the Changes
Possibly related PRs
Suggested labels
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.changeset/ten-parrots-poke.md(0 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/ten-parrots-poke.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog header added for v0.2.81. The## 0.2.81section is correctly inserted. Since there are no patch notes under this header, confirm if any release details should be documented. If this is purely a version-only bump, an empty section is acceptable.packages/thirdweb/CHANGELOG.md (1)
3-8: LGTM! This patch fixes an important authentication issue.The fix addresses a problem where the SIWE (Sign-In with Ethereum) authentication flow was always forcing a chain switch call, which was unnecessary and potentially disruptive to the user experience. This is an important fix for better usability when users authenticate with SIWE.
| { | ||
| "name": "thirdweb", | ||
| "version": "5.100.0", | ||
| "version": "5.100.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump is correct for patch release. The version has been updated from 5.100.0 to 5.100.1 to address the SIWE authentication flow fix. Ensure the corresponding packages/thirdweb/CHANGELOG.md includes a ## 5.100.1 entry documenting this change.
🏁 Script executed:
#!/bin/bash
# Verify the changelog entry for thirdweb v5.100.1 exists
rg --quiet '## 5\\.100\\.1' packages/thirdweb/CHANGELOG.md \
&& echo "✅ Changelog entry found for v5.100.1" \
|| echo "❌ Missing changelog entry for v5.100.1"Length of output: 147
Missing CHANGELOG entry for v5.100.1
The version bump to 5.100.1 is correct, but I couldn’t find a corresponding ## 5.100.1 section in packages/thirdweb/CHANGELOG.md. Please add a new entry documenting the SIWE authentication flow fix before merging.
• packages/thirdweb/CHANGELOG.md: add a
## 5.100.1
- Fix: SIWE authentication flow issue (describe what was corrected)🤖 Prompt for AI Agents
In packages/thirdweb/package.json at line 3, the version has been correctly
bumped to 5.100.1, but the corresponding changelog entry is missing. Add a new
section in packages/thirdweb/CHANGELOG.md with the header ## 5.100.1 and include
a bullet point describing the SIWE authentication flow fix, such as "- Fix: SIWE
authentication flow issue (describe what was corrected)" to properly document
this patch release.
| { | ||
| "name": "@thirdweb-dev/wagmi-adapter", | ||
| "version": "0.2.80", | ||
| "version": "0.2.81", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump is correct for patch release. Updated from 0.2.80 to 0.2.81, matching the release cycle. Verify that packages/wagmi-adapter/CHANGELOG.md contains the ## 0.2.81 header.
🏁 Script executed:
#!/bin/bash
# Verify the changelog entry for wagmi-adapter v0.2.81 exists
rg --quiet '## 0\\.2\\.81' packages/wagmi-adapter/CHANGELOG.md \
&& echo "✅ Changelog entry found for v0.2.81" \
|| echo "❌ Missing changelog entry for v0.2.81"Length of output: 149
Missing CHANGELOG entry for v0.2.81
The packages/wagmi-adapter/CHANGELOG.md is missing a ## 0.2.81 header for the new patch release. Please add a section for v0.2.81 above the previous entries, for example:
File: packages/wagmi-adapter/CHANGELOG.md
+ ## 0.2.81
+
+ - Describe the fixes, improvements or updates included in this patchOnce the changelog is updated, the version bump from 0.2.80 to 0.2.81 can be approved.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "version": "0.2.81", | |
| ## 0.2.81 | |
| - Describe the fixes, improvements or updates included in this patch | |
| ## 0.2.80 |
🤖 Prompt for AI Agents
In packages/wagmi-adapter/CHANGELOG.md, add a new section header for version
0.2.81 above the previous entries to document the patch release corresponding to
the version bump in package.json. This header should be formatted as "## 0.2.81"
and include any relevant changes or notes for this release. This update ensures
the changelog matches the version update in packages/wagmi-adapter/package.json
at line 3.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7105 +/- ##
==========================================
+ Coverage 55.59% 55.60% +0.01%
==========================================
Files 901 901
Lines 58121 58121
Branches 4064 4067 +3
==========================================
+ Hits 32313 32320 +7
+ Misses 25703 25696 -7
Partials 105 105
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
30fafd1Thanks @joaquim-verges! - Fix siwe auth always forcing a switch chain call@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers and changelogs for the
thirdweband@thirdweb-dev/wagmi-adapterpackages, reflecting recent changes and fixes.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.100.0to5.100.1.versioninpackages/wagmi-adapter/package.jsonfrom0.2.80to0.2.81.thirdwebversion5.100.1detailing a fix for siwe auth.Summary by CodeRabbit
Bug Fixes
Chores