Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 21, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Patch Changes

@thirdweb-dev/[email protected]


PR-Codex overview

This PR focuses on updating version numbers and changelogs for the thirdweb and @thirdweb-dev/wagmi-adapter packages, reflecting recent changes and fixes.

Detailed summary

  • Updated version in packages/thirdweb/package.json from 5.100.0 to 5.100.1.
  • Updated version in packages/wagmi-adapter/package.json from 0.2.80 to 0.2.81.
  • Added changelog entry for thirdweb version 5.100.1 detailing a fix for siwe auth.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue where the SIWE (Sign-In with Ethereum) authentication flow would always force a chain switch unnecessarily.
  • Chores

    • Updated package versions for improved tracking and release management.
    • Updated changelogs to reflect the latest patch releases.

@joaquim-verges joaquim-verges requested review from a team as code owners May 21, 2025 06:30
@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 6:40am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 6:40am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 6:40am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 6:40am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 6:40am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Walkthrough

This update removes a changeset file documenting a previous SIWE authentication fix, updates changelogs for the thirdweb and @thirdweb-dev/wagmi-adapter packages to reflect new patch versions, and increments the version numbers in their respective package.json files. No code or public API changes were made.

Changes

File(s) Change Summary
.changeset/ten-parrots-poke.md Removed changeset file documenting a SIWE authentication fix.
packages/thirdweb/CHANGELOG.md, packages/wagmi-adapter/CHANGELOG.md Updated changelogs to add new patch version entries.
packages/thirdweb/package.json, packages/wagmi-adapter/package.json Incremented package versions (thirdweb to 5.100.1, wagmi-adapter to 0.2.81).

Possibly related PRs

Suggested labels

packages, SDK

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 21, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30fafd1 and 76f55fa.

📒 Files selected for processing (5)
  • .changeset/ten-parrots-poke.md (0 hunks)
  • packages/thirdweb/CHANGELOG.md (1 hunks)
  • packages/thirdweb/package.json (1 hunks)
  • packages/wagmi-adapter/CHANGELOG.md (1 hunks)
  • packages/wagmi-adapter/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/ten-parrots-poke.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)

3-4: Changelog header added for v0.2.81. The ## 0.2.81 section is correctly inserted. Since there are no patch notes under this header, confirm if any release details should be documented. If this is purely a version-only bump, an empty section is acceptable.

packages/thirdweb/CHANGELOG.md (1)

3-8: LGTM! This patch fixes an important authentication issue.

The fix addresses a problem where the SIWE (Sign-In with Ethereum) authentication flow was always forcing a chain switch call, which was unnecessary and potentially disruptive to the user experience. This is an important fix for better usability when users authenticate with SIWE.

{
"name": "thirdweb",
"version": "5.100.0",
"version": "5.100.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Version bump is correct for patch release. The version has been updated from 5.100.0 to 5.100.1 to address the SIWE authentication flow fix. Ensure the corresponding packages/thirdweb/CHANGELOG.md includes a ## 5.100.1 entry documenting this change.


🏁 Script executed:

#!/bin/bash
# Verify the changelog entry for thirdweb v5.100.1 exists
rg --quiet '## 5\\.100\\.1' packages/thirdweb/CHANGELOG.md \
  && echo "✅ Changelog entry found for v5.100.1" \
  || echo "❌ Missing changelog entry for v5.100.1"

Length of output: 147


Missing CHANGELOG entry for v5.100.1

The version bump to 5.100.1 is correct, but I couldn’t find a corresponding ## 5.100.1 section in packages/thirdweb/CHANGELOG.md. Please add a new entry documenting the SIWE authentication flow fix before merging.

• packages/thirdweb/CHANGELOG.md: add a

## 5.100.1

- Fix: SIWE authentication flow issue (describe what was corrected)
🤖 Prompt for AI Agents
In packages/thirdweb/package.json at line 3, the version has been correctly
bumped to 5.100.1, but the corresponding changelog entry is missing. Add a new
section in packages/thirdweb/CHANGELOG.md with the header ## 5.100.1 and include
a bullet point describing the SIWE authentication flow fix, such as "- Fix: SIWE
authentication flow issue (describe what was corrected)" to properly document
this patch release.

{
"name": "@thirdweb-dev/wagmi-adapter",
"version": "0.2.80",
"version": "0.2.81",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Version bump is correct for patch release. Updated from 0.2.80 to 0.2.81, matching the release cycle. Verify that packages/wagmi-adapter/CHANGELOG.md contains the ## 0.2.81 header.


🏁 Script executed:

#!/bin/bash
# Verify the changelog entry for wagmi-adapter v0.2.81 exists
rg --quiet '## 0\\.2\\.81' packages/wagmi-adapter/CHANGELOG.md \
  && echo "✅ Changelog entry found for v0.2.81" \
  || echo "❌ Missing changelog entry for v0.2.81"

Length of output: 149


Missing CHANGELOG entry for v0.2.81

The packages/wagmi-adapter/CHANGELOG.md is missing a ## 0.2.81 header for the new patch release. Please add a section for v0.2.81 above the previous entries, for example:

File: packages/wagmi-adapter/CHANGELOG.md

+ ## 0.2.81
+
+ - Describe the fixes, improvements or updates included in this patch

Once the changelog is updated, the version bump from 0.2.80 to 0.2.81 can be approved.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"version": "0.2.81",
## 0.2.81
- Describe the fixes, improvements or updates included in this patch
## 0.2.80
🤖 Prompt for AI Agents
In packages/wagmi-adapter/CHANGELOG.md, add a new section header for version
0.2.81 above the previous entries to document the patch release corresponding to
the version bump in package.json. This header should be formatted as "## 0.2.81"
and include any relevant changes or notes for this release. This update ensures
the changelog matches the version update in packages/wagmi-adapter/package.json
at line 3.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.57 KB (0%) 1.2 s (0%) 168 ms (+160.83% 🔺) 1.3 s
thirdweb (cjs) 309.52 KB (0%) 6.2 s (0%) 570 ms (+1.14% 🔺) 6.8 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 82 ms (+989.95% 🔺) 196 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 24 ms (+683.49% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.5 KB (0%) 390 ms (0%) 73 ms (+497.92% 🔺) 463 ms

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.60%. Comparing base (30fafd1) to head (76f55fa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7105      +/-   ##
==========================================
+ Coverage   55.59%   55.60%   +0.01%     
==========================================
  Files         901      901              
  Lines       58121    58121              
  Branches     4064     4067       +3     
==========================================
+ Hits        32313    32320       +7     
+ Misses      25703    25696       -7     
  Partials      105      105              
Flag Coverage Δ
packages 55.60% <ø> (+0.01%) ⬆️

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants