Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented May 27, 2025

Replaced individual solution page routes with a dynamic route parameter :solution_slug to handle all solution pages through a single route pattern.

Summary by CodeRabbit

  • Refactor
    • Consolidated multiple solution-specific routes into a single dynamic route for more streamlined navigation.

@vercel
Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 6:43pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 27, 2025 6:43pm
login ⬜️ Skipped (Inspect) May 27, 2025 6:43pm
thirdweb_playground ⬜️ Skipped (Inspect) May 27, 2025 6:43pm
wallet-ui ⬜️ Skipped (Inspect) May 27, 2025 6:43pm

@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 18:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 27, 2025 18:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 18:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: a5c4b27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 18:35 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 27, 2025

Walkthrough

The change updates the routing configuration by replacing four separate fixed solution routes with a single dynamic route using a parameterized path segment. This consolidates the handling of solution pages under one unified route pattern, simplifying route definitions.

Changes

File Change Summary
apps/dashboard/framer-rewrites.js Replaced four fixed solution routes with a single dynamic route using a parameterized path.

Sequence Diagram(s)

sequenceDiagram
    User->>DashboardApp: Request /solutions/:solution_slug
    DashboardApp->>RouteHandler: Match dynamic route /solutions/:solution_slug
    RouteHandler->>SolutionPage: Render page for solution_slug
    SolutionPage-->>User: Display solution content
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f115b4d and a5c4b27.

📒 Files selected for processing (1)
  • apps/dashboard/framer-rewrites.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/framer-rewrites.js (1)

30-30:

❓ Verification inconclusive

Good consolidation approach - verify route handling and backward compatibility.

The consolidation of multiple specific solution routes into a single dynamic route pattern is an excellent refactoring that improves maintainability and scalability. This approach reduces code duplication and makes it easier to add new solution pages without modifying this configuration file.

However, please ensure that:

  1. The route handler properly processes the :solution_slug parameter
  2. All previously accessible solution pages still work with the new dynamic pattern
  3. Any hardcoded references to the old specific routes are updated throughout the codebase

🏁 Script executed:

#!/bin/bash
# Description: Verify that solution route handling is properly implemented and no hardcoded references exist
# Expected: Find route handler implementation and any hardcoded solution route references

echo "=== Searching for solution route handler implementation ==="
ast-grep --pattern $'"/solutions/:solution_slug"'
rg -A 10 "/solutions/:" --type js --type ts --type jsx --type tsx

echo "=== Searching for hardcoded solution route references ==="
rg "/solutions/(gaming|consumer-apps|defi|ecosystem)" --type js --type ts --type jsx --type tsx

echo "=== Searching for solution page components or handlers ==="
fd -e js -e ts -e jsx -e tsx | xargs grep -l "solution.*slug\|solutionSlug" 2>/dev/null || true

Length of output: 1278


Good consolidation approach – please verify dynamic route handling and backward compatibility.

Before merging, ensure that:

  • The /solutions/:solution_slug route is handled correctly (the handler or page component reads the solution_slug parameter and loads the corresponding solution).
  • All previously hardcoded solution paths (e.g. /solutions/gaming, /solutions/defi, etc.) are either redirected or updated to work with the new dynamic pattern.
  • No lingering references to the old fixed routes remain in the codebase (our automated scan didn’t find any in JS/TS files).
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member Author

jnsdls commented May 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 27, 2025
@jnsdls jnsdls marked this pull request as ready for review May 27, 2025 18:35
@jnsdls jnsdls requested review from a team as code owners May 27, 2025 18:35
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (f115b4d) to head (a5c4b27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7175   +/-   ##
=======================================
  Coverage   55.67%   55.67%           
=======================================
  Files         904      904           
  Lines       58391    58391           
  Branches     4119     4119           
=======================================
  Hits        32510    32510           
  Misses      25775    25775           
  Partials      106      106           
Flag Coverage Δ
packages 55.67% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 61.75 KB (0%) 1.3 s (0%) 234 ms (+195.94% 🔺) 1.5 s
thirdweb (cjs) 344.4 KB (0%) 6.9 s (0%) 712 ms (+22.04% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 88 ms (+1713.11% 🔺) 202 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 34 ms (+2214.42% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 152 ms (+1145.75% 🔺) 543 ms

@jnsdls jnsdls merged commit 5edfb81 into main May 27, 2025
27 checks passed
@jnsdls jnsdls deleted the _Dashboard_consolidate_solution_page_rewrites_with_dynamic_slug branch May 27, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants