feat: redesign aggregate parameter input with improved UI #7179

catalyst17 · 2025-05-27T23:54:46Z

[Dashboard] Feature: Redesign Aggregate Parameter Input Component

Notes for the reviewer

This PR completely redesigns the aggregate parameter input component with a more user-friendly interface. The new design uses a popover pattern instead of the previous MultiSelect approach, making it easier to view and select aggregation presets.

How to test

Open any insight blueprint that uses aggregation
Click on the aggregate parameter input
Test searching for presets, selecting/deselecting options
Verify that manual text entry still works in the textarea
Check that the selected aggregations display correctly when the popover is closed

PR-Codex overview

This PR focuses on enhancing the AggregateParameterInput component by improving the UI and functionality for selecting aggregation presets. It introduces a popover for preset selection, updates the presets structure, and refines the handling of user input.

Detailed summary

Removed unnecessary className concatenation in the asChild component.
Updated AggregateParameterInput to use a popover for preset selection.
Added new preset IDs for better identification.
Enhanced filtering and selection logic for presets.
Replaced MultiSelect with a custom dropdown using Checkbox and Popover.
Improved user experience with better input handling and search functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2025-05-27T23:54:50Z

⚠️ No Changeset found

Latest commit: 4705a59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-05-27T23:54:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2025 9:51pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	May 28, 2025 9:51pm
login	⬜️ Skipped (Inspect)	May 28, 2025 9:51pm
thirdweb-www	⬜️ Skipped (Inspect)	May 28, 2025 9:51pm
wallet-ui	⬜️ Skipped (Inspect)	May 28, 2025 9:51pm

coderabbitai · 2025-05-27T23:54:52Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

catalyst17 · 2025-05-27T23:55:08Z

feat: redesign aggregate parameter input with improved UI #7179 👈 (View in Graphite)
feat: enhance aggregate parameter input with multi-select presets #7168 : 1 other dependent PR (#7169 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-05-27T23:57:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.66%. Comparing base (f7331f1) to head (4705a59).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7179   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         904      904           
  Lines       58400    58400           
  Branches     4116     4116           
=======================================
  Hits        32510    32510           
  Misses      25784    25784           
  Partials      106      106

Flag	Coverage Δ
packages	`55.66% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-28T00:00:01Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	61.75 KB (0%)	1.3 s (0%)	212 ms (+165.26% 🔺)	1.5 s
thirdweb (cjs)	344.4 KB (0%)	6.9 s (0%)	656 ms (+11.67% 🔺)	7.6 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	79 ms (+1834.11% 🔺)	193 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	24 ms (+1443.62% 🔺)	34 ms
thirdweb/react (minimal + tree-shaking)	19.54 KB (0%)	391 ms (0%)	103 ms (+845.65% 🔺)	493 ms

graphite-app · 2025-05-28T21:40:09Z

Merge activity

May 28, 9:40 PM UTC: MananTank added this pull request to the Graphite merge queue.
May 28, 9:54 PM UTC: Merged by the Graphite merge queue.

# [Dashboard] Feature: Redesign Aggregate Parameter Input Component ## Notes for the reviewer This PR completely redesigns the aggregate parameter input component with a more user-friendly interface. The new design uses a popover pattern instead of the previous MultiSelect approach, making it easier to view and select aggregation presets. ## How to test 1. Open any insight blueprint that uses aggregation 2. Click on the aggregate parameter input 3. Test searching for presets, selecting/deselecting options 4. Verify that manual text entry still works in the textarea 5. Check that the selected aggregations display correctly when the popover is closed

vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 23:54 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 23:54 Inactive

vercel bot temporarily deployed to Preview – login May 27, 2025 23:54 Inactive

vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 23:54 Inactive

github-actions bot assigned catalyst17 May 27, 2025

github-actions bot added the Playground Changes involving the Playground codebase. label May 27, 2025

catalyst17 mentioned this pull request May 27, 2025

feat: enhance aggregate parameter input with multi-select presets #7168

Merged

catalyst17 requested review from AmineAfia and MananTank May 27, 2025 23:55

catalyst17 mentioned this pull request May 27, 2025

refactor: improve aggregate parameter input with MultiSelect #7169

Closed

catalyst17 marked this pull request as ready for review May 27, 2025 23:55

catalyst17 requested review from a team as code owners May 27, 2025 23:55

vercel bot deployed to Preview – thirdweb_playground May 27, 2025 23:57 View deployment

MananTank approved these changes May 28, 2025

View reviewed changes

graphite-app bot force-pushed the feat_enhance_aggregate_parameter_input_with_multi-select_presets branch from b1d6b81 to f7331f1 Compare May 28, 2025 21:48

graphite-app bot force-pushed the feat_redesign_aggregate_parameter_input_with_improved_UI branch from dff69a4 to 4705a59 Compare May 28, 2025 21:49

vercel bot temporarily deployed to Preview – docs-v2 May 28, 2025 21:49 Inactive

vercel bot temporarily deployed to Preview – login May 28, 2025 21:49 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www May 28, 2025 21:49 Inactive

vercel bot temporarily deployed to Preview – wallet-ui May 28, 2025 21:49 Inactive

vercel bot deployed to Preview – thirdweb_playground May 28, 2025 21:51 View deployment

Base automatically changed from feat_enhance_aggregate_parameter_input_with_multi-select_presets to main May 28, 2025 21:52

graphite-app bot merged commit 4705a59 into main May 28, 2025
21 of 22 checks passed

graphite-app bot deleted the feat_redesign_aggregate_parameter_input_with_improved_UI branch May 28, 2025 21:54

vercel bot temporarily deployed to Production – thirdweb-www May 28, 2025 21:54 Inactive

vercel bot temporarily deployed to Production – login May 28, 2025 21:54 Inactive

vercel bot temporarily deployed to Production – docs-v2 May 28, 2025 21:54 Inactive

vercel bot temporarily deployed to Production – wallet-ui May 28, 2025 21:54 Inactive

vercel bot deployed to Production – thirdweb_playground May 28, 2025 21:58 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: redesign aggregate parameter input with improved UI #7179

feat: redesign aggregate parameter input with improved UI #7179

Uh oh!

catalyst17 commented May 27, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented May 27, 2025 •

edited

Loading

Uh oh!

vercel bot commented May 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 27, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

catalyst17 commented May 27, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

graphite-app bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: redesign aggregate parameter input with improved UI #7179

feat: redesign aggregate parameter input with improved UI #7179

Uh oh!

Conversation

catalyst17 commented May 27, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Dashboard] Feature: Redesign Aggregate Parameter Input Component

Notes for the reviewer

How to test

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

catalyst17 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 28, 2025

size-limit report 📦

Uh oh!

graphite-app bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

catalyst17 commented May 27, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented May 27, 2025 •

edited

Loading

vercel bot commented May 27, 2025 •

edited

Loading

coderabbitai bot commented May 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

catalyst17 commented May 27, 2025 •

edited

Loading

codecov bot commented May 27, 2025 •

edited

Loading

graphite-app bot commented May 28, 2025 •

edited

Loading