-
Notifications
You must be signed in to change notification settings - Fork 619
[Docs] Update Broken Link #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" WalkthroughThe FAQ page for the Buy With Crypto feature was updated to clarify how developers can set additional fees on swap transactions via the project page, and the link to supported chains was changed to an absolute URL. An unnecessary blank line was also removed. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to content updates and link modifications in documentation. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/app/pay/faqs/page.mdx (1)
19-19: Fix punctuation and improve clarity in the fee-setting instruction.The hyphen is misplaced and the phrase is redundant. Simplify to:
- For buying with crypto or swap fees, thirdweb charges a 0.3% protocol fee. Developers may monetize their application by charging additional fees on swap transactions. To set a fee- in your project page, navigate to Universal Bridge > Settings to set this fee. + For buying with crypto or swap fees, thirdweb charges a 0.3% protocol fee. Developers may monetize their application by charging additional fees on swap transactions. To set a fee, navigate to Universal Bridge > Settings on your project page.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/portal/src/app/pay/faqs/page.mdx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/pay/faqs/page.mdx (1)
104-104:✅ Verification successful
Verify that the new absolute link resolves correctly.
Please confirm that the updated URL returns a successful response and doesn’t 404.
🏁 Script executed:
#!/bin/bash # Check HTTP status of the updated supported-chains link curl --silent --head --fail \ --write-out "%{http_code}\n" \ "https://thirdweb.com/chainlist?service=pay"Length of output: 2032
Link verification successful
The updated link in apps/portal/src/app/pay/faqs/page.mdx (line 104) returns HTTP 200 and resolves correctly. No further action required.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7319 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58673 58673
Branches 4158 4158
=======================================
Hits 32607 32607
Misses 25959 25959
Partials 107 107
🚀 New features to boost your workflow:
|
Merge activity
|
size-limit report 📦
|
CORE-0000
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the content in the `page.mdx` file related to fees and support for the `Universal Bridge` feature.
### Detailed summary
- Updated the explanation of fees for "Buy With Crypto" to specify fee settings in the project page.
- Revised the link for supported cryptocurrencies to direct to a new URL with a specific service.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Documentation**
- Clarified FAQ entry about setting additional fees for swap transactions and provided step-by-step instructions for configuring these fees.
- Updated the "supported chains" link in the FAQ to use an absolute URL.
- Removed an unnecessary blank line for improved readability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
58d6bd3 to
62af256
Compare
CORE-0000
PR-Codex overview
This PR updates the content in the
page.mdxfile related to FAQs for the Universal Bridge, providing clearer information about fees and supported cryptocurrencies.Detailed summary
Summary by CodeRabbit