Skip to content

Fix comment for max claimable tokens test in drop721.test.ts #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2025
Merged

Fix comment for max claimable tokens test in drop721.test.ts #7336

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a8977f
Update drop721.test.ts
vtjl10 Jun 13, 2025
878979d
Update drop721.test.ts
vtjl10 Jun 21, 2025
382f1ec
Merge branch 'main' into main
jnsdls Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/thirdweb/src/extensions/erc721/drop721.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
).resolves.toBe(1n);

// we try to claim an extra `2` tokens
// this should faile bcause the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet)
// this should faile because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet)
Copy link
Contributor

@graphite-app graphite-app bot Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a typo in the comment: faile should be fail. The correction is important for maintaining documentation quality, especially since this PR is specifically focused on improving comment clarity.

Suggested change
// this should faile because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet)
// this should fail because the max claimable is `3` and we have previously already claimed 2 tokens (one for ourselves, one for the other wallet)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

// NOTE: this relies on the previous tests, we should extract this and properly re-set tests every time
// this probably requires re-deploying contracts for every test => clean slate
await expect(
Expand Down