Skip to content

[TOOL-4821] Improve Team members search #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

[TOOL-4821] Improve Team members search #7346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ...shboard/src/app/(app)/team/[team_slug]/(team)/~/settings/members/ManageMembersSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import { useMutation } from "@tanstack/react-query";
import Fuse from "fuse.js";
import { EllipsisIcon } from "lucide-react";
import { useMemo, useState } from "react";
import { toast } from "sonner";
Expand All @@ -41,13 +42,21 @@ export function ManageMembersSection(props: {
const [role, setRole] = useState<RoleFilterValue>("ALL ROLES");
const [sortBy, setSortBy] = useState<MemberSortId>("date");

const membersIndex = useMemo(() => {
return new Fuse(props.members, {
keys: [
{ name: "account.name", weight: 2 },
{ name: "account.email", weight: 1 },
],
threshold: 0.3,
});
}, [props.members]);

const membersToShow = useMemo(() => {
let value = props.members;

if (searchTerm) {
value = value.filter((m) =>
m.account.name.toLowerCase().includes(searchTerm.toLowerCase()),
);
value = membersIndex.search(searchTerm).map((result) => result.item);
}

value = value.filter((m) => !deletedMembersIds.includes(m.accountId));
Expand Down Expand Up @@ -76,7 +85,14 @@ export function ManageMembersSection(props: {
}

return value;
}, [role, props.members, sortBy, deletedMembersIds, searchTerm]);
}, [
role,
props.members,
sortBy,
deletedMembersIds,
searchTerm,
membersIndex,
]);

if (!props.userHasEditPermission) {
topSection = (
Expand Down
Loading