[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address #7416

0xFirekeeper · 2025-06-23T17:53:48Z

Changed the NATIVE_TOKEN_ADDRESS constant to use the checksummed version as some services might have checks for it.

PR-Codex overview

This PR updates the NATIVE_TOKEN_ADDRESS constant to a new address format and modifies the isNativeTokenAddress function to use getAddress for comparison, ensuring address normalization.

Detailed summary

Updated NATIVE_TOKEN_ADDRESS from "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee" to "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE".
Changed isNativeTokenAddress to use getAddress for both the input address and NATIVE_TOKEN_ADDRESS for case-insensitive comparison.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Chores
- Updated the format of the native token address to use a checksummed Ethereum address for improved consistency and readability.

Changed the NATIVE_TOKEN_ADDRESS constant to use the checksummed version as some services might have checks for it.

changeset-bot · 2025-06-23T17:53:54Z

⚠️ No Changeset found

Latest commit: 681fd33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-23T17:53:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Updated (UTC)
docs-v2	❌ Failed (Inspect)	Jun 23, 2025 6:04pm
nebula	❌ Failed (Inspect)	Jun 23, 2025 6:04pm
thirdweb_playground	❌ Failed (Inspect)	Jun 23, 2025 6:04pm
thirdweb-www	❌ Failed (Inspect)	Jun 23, 2025 6:04pm
wallet-ui	❌ Failed (Inspect)	Jun 23, 2025 6:04pm

graphite-app · 2025-06-23T17:53:57Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai · 2025-06-23T17:53:57Z

Caution

Review failed

The pull request is closed.

Walkthrough

The constant NATIVE_TOKEN_ADDRESS was updated from a lowercase hexadecimal string to a checksummed mixed-case Ethereum address format. The isNativeTokenAddress function now uses the getAddress utility for checksum-normalized address comparison instead of a simple lowercase string comparison. No other logic or control flow was changed.

Changes

File(s)	Change Summary
packages/thirdweb/src/constants/addresses.ts	Updated `NATIVE_TOKEN_ADDRESS` to a checksummed mixed-case address and modified `isNativeTokenAddress` to use checksum normalization for comparisons.

Suggested labels

packages, SDK

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 234bd40 and 681fd33.

📒 Files selected for processing (1)

packages/thirdweb/src/constants/addresses.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11b4d9e and 234bd40.

📒 Files selected for processing (1)

packages/thirdweb/src/constants/addresses.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.@(ts|tsx)`: Accept a typed 'props' object and export a named function (e.g., export function MyComponent()). Combine class names via 'cn', expose 'className' prop if useful. ...

**/*.@(ts|tsx): Accept a typed 'props' object and export a named function (e.g., export function MyComponent()).
Combine class names via 'cn', expose 'className' prop if useful.
Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Local state or effects live inside; data fetching happens in hooks.
Merge class names with 'cn' from '@/lib/utils' to keep conditional logic readable.
Stick to design-tokens: background ('bg-card'), borders ('border-border'), muted text ('text-muted-foreground') etc.
Use the 'container' class with a 'max-w-7xl' cap for page width consistency.
Spacing utilities ('px-', 'py-', 'gap-*') are preferred over custom margins.
Responsive helpers follow mobile-first ('max-sm', 'md', 'lg', 'xl').
Never hard-code colors – always go through Tailwind variables.
Tailwind CSS is the styling system – avoid inline styles or CSS modules.
Prefix files with 'import "server-only";' so they never end up in the client bundle (for server-only code).

packages/thirdweb/src/constants/addresses.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/thirdweb/src/constants/addresses.ts (2)

5-5: Verify the checksummed address format is standard.

Please confirm that this specific checksummed format for the native token sentinel address is the standard used across the ecosystem.
What is the correct checksummed format for the Ethereum native token sentinel address 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee?
4-5: ```shell
#!/usr/bin/env bash

Description: Correctly search for all usages of NATIVE_TOKEN_ADDRESS and related patterns using globs

echo "=== Searching for NATIVE_TOKEN_ADDRESS usage ==="
rg -g '.ts' -g '.tsx' -n -A3 -B1 "NATIVE_TOKEN_ADDRESS"

echo -e "\n=== Searching for hardcoded lowercase version of the native address ==="
rg -g '.ts' -g '.tsx' -n "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"

echo -e "\n=== Searching for direct string comparisons with the constant ==="
rg -g '.ts' -g '.tsx' -n -E "(===\sNATIVE_TOKEN_ADDRESS|NATIVE_TOKEN_ADDRESS\s===)"

echo -e "\n=== Searching for toLowerCase or toUpperCase operations around the constant ==="
rg -g '.ts' -g '.tsx' -n -C2 "(NATIVE_TOKEN_ADDRESS.*.toLowerCase|.toLowerCase.NATIVE_TOKEN_ADDRESS|NATIVE_TOKEN_ADDRESS..toUpperCase|.toUpperCase.*NATIVE_TOKEN_ADDRESS)"
</details>

</blockquote></details>

</details>

packages/thirdweb/src/constants/addresses.ts

0xFirekeeper · 2025-06-23T17:58:39Z

Some users might have equality checks somewhere, probably shouldn't do this on second thought

[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address

234bd40

Changed the NATIVE_TOKEN_ADDRESS constant to use the checksummed version as some services might have checks for it.

0xFirekeeper requested review from a team as code owners June 23, 2025 17:53

github-actions bot assigned 0xFirekeeper Jun 23, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jun 23, 2025

coderabbitai bot reviewed Jun 23, 2025

View reviewed changes

packages/thirdweb/src/constants/addresses.ts Show resolved Hide resolved

vercel bot deployed to Preview – nebula June 23, 2025 17:56 View deployment

vercel bot deployed to Preview – wallet-ui June 23, 2025 17:56 View deployment

equality check

681fd33

vercel bot had a problem deploying to Preview – wallet-ui June 23, 2025 17:58 Failure

vercel bot had a problem deploying to Preview – nebula June 23, 2025 17:58 Failure

0xFirekeeper closed this Jun 23, 2025

vercel bot had a problem deploying to Preview – thirdweb_playground June 23, 2025 17:59 Failure

vercel bot had a problem deploying to Preview – thirdweb-www June 23, 2025 18:02 Failure

vercel bot had a problem deploying to Preview – docs-v2 June 23, 2025 18:04 Failure

0xFirekeeper deleted the firekeeper/checksum-native branch June 24, 2025 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address #7416

[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address #7416

Uh oh!

0xFirekeeper commented Jun 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 23, 2025

Uh oh!

coderabbitai bot commented Jun 23, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Description: Correctly search for all usages of NATIVE_TOKEN_ADDRESS and related patterns using globs

Uh oh!

Uh oh!

0xFirekeeper commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address #7416

[SDK] Update NATIVE_TOKEN_ADDRESS to checksummed address #7416

Uh oh!

Conversation

0xFirekeeper commented Jun 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 23, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Suggested labels

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Description: Correctly search for all usages of NATIVE_TOKEN_ADDRESS and related patterns using globs

Uh oh!

Uh oh!

0xFirekeeper commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xFirekeeper commented Jun 23, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jun 23, 2025 •

edited

Loading

vercel bot commented Jun 23, 2025 •

edited

Loading

coderabbitai bot commented Jun 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)