Skip to content

add eoa execution options type #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

add eoa execution options type #7428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce8ae2
add eoa execution options type
d4mr Jun 24, 2025
a2f1911
fix build errors
d4mr Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions packages/engine/src/client/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,28 @@ export type AaZksyncExecutionOptions = {
chainId: string;
};

/**
* Uses EOA for execution. Only supported for signing currently.
*/
export type EoaExecutionOptions = {
type: "eoa";

/**
* The EOA address
*/
address: string;

/**
* The chain id of the transaction
*/
chainId: string;

/**
* The idempotency key of the transaction. Transaction requests sent with the same idempotency key will be de-duplicated. If not provided, a randomUUID will be generated. This is also used as the ID of a queued/stored transaction.
*/
idempotencyKey?: string;
};

export type ListAccountsData = {
body?: never;
path?: never;
Expand Down Expand Up @@ -434,7 +456,8 @@ export type SignTransactionData = {
executionOptions:
| AutoExecutionOptions
| AaExecutionOptions
| AaZksyncExecutionOptions;
| AaZksyncExecutionOptions
| EoaExecutionOptions;
params: Array<{
/**
* The recipient address
Expand Down Expand Up @@ -585,7 +608,8 @@ export type SignMessageData = {
executionOptions:
| AutoExecutionOptions
| AaExecutionOptions
| AaZksyncExecutionOptions;
| AaZksyncExecutionOptions
| EoaExecutionOptions;
params: Array<{
/**
* The message to sign
Expand Down Expand Up @@ -661,7 +685,8 @@ export type SignTypedDataData = {
executionOptions:
| AutoExecutionOptions
| AaExecutionOptions
| AaZksyncExecutionOptions;
| AaZksyncExecutionOptions
| EoaExecutionOptions;
params: Array<{
domain: {
chainId?: number | number;
Expand Down
4 changes: 3 additions & 1 deletion packages/thirdweb/src/engine/server-wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {
type AaExecutionOptions,
type AaZksyncExecutionOptions,
type EoaExecutionOptions,
sendTransaction,
signMessage,
signTypedData,
Expand Down Expand Up @@ -46,7 +47,8 @@ export type ServerWalletOptions = {
*/
executionOptions?:
| Omit<AaExecutionOptions, "chainId">
| Omit<AaZksyncExecutionOptions, "chainId">;
| Omit<AaZksyncExecutionOptions, "chainId">
| Omit<EoaExecutionOptions, "chainId">;
};

export type ServerWallet = Account & {
Expand Down
Loading