Skip to content

[SDK] Chore: Remove onrampTokenAddress set to ETH #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025
Merged

[SDK] Chore: Remove onrampTokenAddress set to ETH #7441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aea2245
chore: remove onrampTokenAddress set to ETH
gregfromstl Jun 25, 2025
61fed8c
fix: onramp step label
gregfromstl Jun 25, 2025
9f42f55
fix: onramp transactions missing chain and client
gregfromstl Jun 25, 2025
3562a50
fix: slight delay after fee and approvals for rpc catch up
gregfromstl Jun 25, 2025
befed30
changeset
gregfromstl Jun 25, 2025
3d8869a
lint
gregfromstl Jun 25, 2025
920c7e0
fix: error message when no onramp quotes exist
gregfromstl Jun 25, 2025
e9a7773
feat: cleanup step preview ui
gregfromstl Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/thirdweb/src/pay/buyWithFiat/getQuote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
maxSteps: 2,
onramp: onrampProvider,
onrampChainId: params.onrampChainId,
onrampTokenAddress: params.onrampTokenAddress ?? NATIVE_TOKEN_ADDRESS,
onrampTokenAddress: params.onrampTokenAddress,

Check warning on line 329 in packages/thirdweb/src/pay/buyWithFiat/getQuote.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/pay/buyWithFiat/getQuote.ts#L329 

Added line #L329 was not covered by tests
paymentLinkId: params.paymentLinkId,
purchaseData: params.purchaseData,
receiver: params.toAddress, // force onramp to native token to avoid missing gas issues
Expand Down
2 changes: 0 additions & 2 deletions packages/thirdweb/src/react/web/ui/Bridge/QuoteLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { useEffect } from "react";
import { trackPayEvent } from "../../../../analytics/track/pay.js";
import type { Token } from "../../../../bridge/types/Token.js";
import type { ThirdwebClient } from "../../../../client/client.js";
import { NATIVE_TOKEN_ADDRESS } from "../../../../constants/addresses.js";
import { toUnits } from "../../../../utils/units.js";
import {
type BridgePrepareRequest,
Expand Down Expand Up @@ -191,7 +190,6 @@ function getBridgeParams(args: {
currency: paymentMethod.currency,
enabled: !!(destinationToken && amount && client),
onramp: paymentMethod.onramp || "coinbase",
onrampTokenAddress: NATIVE_TOKEN_ADDRESS,
paymentLinkId: args.paymentLinkId,
purchaseData: args.purchaseData,
receiver,
Expand Down
3 changes: 2 additions & 1 deletion packages/thirdweb/src/react/web/ui/Bridge/StepRunner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@

<Container flex="column" gap="3xs" style={{ flex: 1 }}>
<Text color="primaryText" size="sm">
TEST
{request.onramp.slice(0, 1).toUpperCase() +
request.onramp.slice(1)}

Check warning on line 326 in packages/thirdweb/src/react/web/ui/Bridge/StepRunner.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/Bridge/StepRunner.tsx#L325-L326 

Added lines #L325 - L326 were not covered by tests
</Text>
<Text color="secondaryText" size="xs">
{getStepStatusText(onrampStatus)}
Expand Down
Loading