Skip to content

[Dashboard] Fix validation for smart account options #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

[Dashboard] Fix validation for smart account options #7522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0534aba
Enhance smart account factory address validation in auth options form
cursoragent Jul 4, 2025
bf5b060
fix
joaquim-verges Jul 4, 2025
4842fe2
lint
joaquim-verges Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .../~/ecosystem/[slug]/(active)/configuration/components/client/auth-options-form.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ export function AuthOptionsForm({
(data) => {
if (
data.useSmartAccount &&
data.executionMode === "EIP4337" &&
data.accountFactoryType === "custom" &&
data.customAccountFactoryAddress &&
!isAddress(data.customAccountFactoryAddress)
) {
Expand All @@ -145,6 +147,23 @@ export function AuthOptionsForm({
path: ["customAccountFactoryAddress"],
},
)
.refine(
(data) => {
if (
data.useSmartAccount &&
data.executionMode === "EIP4337" &&
data.accountFactoryType === "custom" &&
!data.customAccountFactoryAddress
) {
return false;
}
return true;
},
{
message: "Please enter a custom account factory address",
path: ["customAccountFactoryAddress"],
},
)
.refine(
(data) => {
if (data.useSmartAccount && (data.defaultChainId ?? 0) <= 0) {
Expand Down Expand Up @@ -212,7 +231,7 @@ export function AuthOptionsForm({
}

let smartAccountOptions: Ecosystem["smartAccountOptions"] | null = null;
if (data.useSmartAccount) {
if (data.useSmartAccount && data.executionMode === "EIP4337") {
let accountFactoryAddress: string;
switch (data.accountFactoryType) {
case "v0.6":
Expand Down
Loading