Skip to content

[SDK] Fix inapp wallets showing up in all wallets list #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

[SDK] Fix inapp wallets showing up in all wallets list #7586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tangy-otters-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix inapp wallets showing up in all wallets list
4 changes: 4 additions & 0 deletions packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ export function AllWalletsList(
.filter(
(info) => !externalWallets.find((wallet) => wallet.id === info.id),
)
.filter(
(info) =>
info.id !== "inApp" && info.id !== "embedded" && info.id !== "smart",
)
.filter((info) => info.hasMobileSupport);

const fuse = new Fuse(filteredWallets, {
Expand Down
13 changes: 10 additions & 3 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,16 @@
const setSelectionData = useSetSelectionData();

const walletList = useMemo(() => {
return walletInfos.filter((wallet) => {
return props.specifiedWallets.findIndex((x) => x.id === wallet.id) === -1;
});
return walletInfos
.filter((wallet) => {
return (
props.specifiedWallets.findIndex((x) => x.id === wallet.id) === -1

Check warning on line 45 in packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx#L42-L45 

Added lines #L42 - L45 were not covered by tests
);
})
.filter(
(info) =>
info.id !== "inApp" && info.id !== "embedded" && info.id !== "smart",
);

Check warning on line 51 in packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx#L47-L51 

Added lines #L47 - L51 were not covered by tests
}, [props.specifiedWallets]);

const fuseInstance = useMemo(() => {
Expand Down
Loading