Skip to content

[Docs] Redesign sidebar and update wallet documentation #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

[Docs] Redesign sidebar and update wallet documentation #7602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/portal/knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"src/pages/**/*.{js,jsx,ts,tsx}",
"scripts/*.ts"
],
"ignore": ["src/components/ui/**", "src/icons/**"],
"ignore": ["src/components/ui/**", "src/icons/**", "src/components/others/Banner.tsx"],
"ignoreBinaries": ["only-allow"],
"ignoreDependencies": [
"@thirdweb-dev/chains",
Expand Down
6 changes: 3 additions & 3 deletions apps/portal/public/llms-full.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ const client = createThirdwebClient({ clientId: "YOUR_CLIENT_ID" });
/>;
```

[View all available wallets](https://portal.thirdweb.com/typescript/v5/supported-wallets)
[View all available wallets](https://portal.thirdweb.com/connect/external-wallets)

#### Customizing the default chain to connect to

Expand Down Expand Up @@ -1133,7 +1133,7 @@ const client = createThirdwebClient({ clientId: "YOUR_CLIENT_ID" });
/>;
```

[View all available wallets](https://portal.thirdweb.com/typescript/v5/supported-wallets)
[View all available wallets](https://portal.thirdweb.com/connect/external-wallets)

#### Customizing the default chain to connect to

Expand Down Expand Up @@ -45137,7 +45137,7 @@ Creates a wallet based on the provided ID and arguments.
* Supports 500+ wallets
* Handles both injected browser wallets and WalletConnect sessions

[View all available wallets](https://portal.thirdweb.com/typescript/v5/supported-wallets)
[View all available wallets](https://portal.thirdweb.com/connect/external-wallets)

### Example

Expand Down
11 changes: 8 additions & 3 deletions apps/portal/redirects.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,6 @@ const walletRedirects = {
"/connect/wallet/sign-in-methods/configure",

"/connect/sign-in/overview": "/connect/wallet/overview",
"/connect/supported-wallets": "/connect/connect",
"/connect/usage-with-react-native-sdk": "/connect/sign-in",
"/connect/usage-with-react-sdk": "/connect/sign-in",
"/connect/usage-with-typescript-sdk": "/connect/sign-in",
Expand Down Expand Up @@ -1039,8 +1038,8 @@ const v4ToV5Redirects = {
"/react-native/v0/:path*": "/react-native/v5",
"/react/v4": "/react/v5",
"/react/v4/:path*": "/react/v5",
"/references/wallets": "/typescript/v5/supported-wallets",
"/references/wallets/:path*": "/typescript/v5/supported-wallets",
"/references/wallets": "/connect/external-wallets",
"/references/wallets/:path*": "/connect/external-wallets",
"/storage-sdk/v2": "/typescript/v5/storage",
"/storage-sdk/v2/:path*": "/typescript/v5/storage",
"/typescript/v4": "/typescript/v5",
Expand Down Expand Up @@ -1071,6 +1070,11 @@ const payRedirects = {
"/connect/pay/webhooks": "/pay/webhooks",
};

const walletRefactorRedirects = {
"/typescript/v5/supported-wallets": "/connect/external-wallets",
"/typescript/v5/supported-wallets/:path*": "/connect/external-wallets/:path*",
};

/**
* @type {import('next').NextConfig['redirects']}
*/
Expand All @@ -1092,6 +1096,7 @@ export const redirects = async () => {
...createRedirects(v4ToV5Redirects),
...createRedirects(glossaryRedirects),
...createRedirects(payRedirects),
...createRedirects(walletRefactorRedirects),
];
};

Expand Down
14 changes: 11 additions & 3 deletions apps/portal/src/app/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ export const connectLinks: Array<{
] as const;

const apisLinks = [
{
href: "https://engine.thirdweb.com/reference",
name: "Engine",
},
{
href: "https://insight.thirdweb.com/reference",
name: "Insight",
Expand All @@ -135,21 +139,25 @@ const apisLinks = [
href: "https://bridge.thirdweb.com/reference",
name: "Universal Bridge",
},
{
href: "/connect/account-abstraction/api",
name: "Bundler",
},
];

const sdkLinks = [
{
href: "/typescript/v5",
href: "/references/typescript/v5",
icon: TypeScriptIcon,
name: "TypeScript",
},
{
href: "/react/v5",
href: "/references/typescript/v5",
icon: ReactIcon,
name: "React",
},
{
href: "/react-native/v5",
href: "/references/typescript/v5",
icon: ReactIcon,
name: "React Native",
},
Comment on lines +150 to 163
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify the consolidation of all SDK links to TypeScript references.

All three SDK entries (TypeScript, React, React Native) now point to /references/typescript/v5, which differs from their distinct names. This could confuse users expecting platform-specific documentation.

Please verify that this consolidation is intentional and aligns with the unified SDK documentation structure:

🏁 Script executed:

#!/bin/bash
# Description: Check if React and React Native specific reference pages exist
# Expected: If separate pages exist, the links should point to them instead

echo "Checking for React-specific reference pages:"
fd -t f "page.mdx" apps/portal/src/app/react/v5 | head -5

echo -e "\nChecking for React Native-specific reference pages:"
fd -t f "page.mdx" apps/portal/src/app/react-native/v5 | head -5

echo -e "\nChecking current TypeScript references structure:"
fd -t f "page.mdx" apps/portal/src/app/references/typescript/v5 | head -5

Length of output: 1228

Incorrect SDK link consolidation—restore platform-specific docs

The React and React Native entries in the sdkLinks array currently point to the TypeScript docs (/references/typescript/v5), but dedicated pages exist under /react/v5 and /react-native/v5. Update the links so users land on the correct platform documentation.

• File: apps/portal/src/app/Header.tsx (lines 142–155)

  • Replace React href with /react/v5
  • Replace React Native href with /react-native/v5

Diff:

   {
-    href: "/references/typescript/v5",
+    href: "/react/v5",
     icon: ReactIcon,
     name: "React",
   },
   {
-    href: "/references/typescript/v5",
+    href: "/react-native/v5",
     icon: ReactIcon,
     name: "React Native",
   },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
href: "/references/typescript/v5",
icon: TypeScriptIcon,
name: "TypeScript",
},
{
href: "/react/v5",
href: "/references/typescript/v5",
icon: ReactIcon,
name: "React",
},
{
href: "/react-native/v5",
href: "/references/typescript/v5",
icon: ReactIcon,
name: "React Native",
},
{
href: "/references/typescript/v5",
icon: TypeScriptIcon,
name: "TypeScript",
},
{
href: "/react/v5",
icon: ReactIcon,
name: "React",
},
{
href: "/react-native/v5",
icon: ReactIcon,
name: "React Native",
},
🤖 Prompt for AI Agents 
In apps/portal/src/app/Header.tsx between lines 142 and 155, the href links for
React and React Native in the sdkLinks array incorrectly point to the TypeScript
documentation URL. Update the React href to "/react/v5" and the React Native
href to "/react-native/v5" to ensure users are directed to the correct
platform-specific documentation pages.

Expand Down
Loading
Loading