[Portal] Payments Docs #7651
Merged
[Portal] Payments Docs #7651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
WalkthroughThis update introduces a major overhaul of the documentation and navigation structure, particularly in the portal application. The "connect" and "pay" sections are deprecated and replaced with new "wallets" and "payments" sections, each with revised layouts, sidebars, and content. Numerous documentation pages related to account abstraction, in-app wallets, and payment guides are removed or migrated. New payments documentation and guides are added, with updated navigation and sidebar structures. UI components and styles are refined for headings, lists, buttons, tabs, sidebars, and layout containers, focusing on typography, spacing, and color schemes. Some code components are updated for class name simplification and export adjustments. Changes
Sequence Diagram(s)Payments Flow (New Documentation)sequenceDiagram
participant Developer
participant SDK/React Widget
participant Payments API
participant Blockchain
Developer->>SDK/React Widget: Install and configure client
Developer->>SDK/React Widget: Prepare payment (Buy/Sell/Transfer)
SDK/React Widget->>Payments API: Request payment quote
Payments API-->>SDK/React Widget: Return quote (steps, tokens, metadata)
Developer->>SDK/React Widget: Execute payment transactions
SDK/React Widget->>Blockchain: Submit transactions (approval, swap, transfer)
Blockchain-->>SDK/React Widget: Confirm transaction(s)
SDK/React Widget->>Payments API: Poll for status (if cross-chain)
Payments API-->>SDK/React Widget: Return status (PENDING/COMPLETED/FAILED)
SDK/React Widget-->>Developer: Payment result and status
Sidebar and Navigation RefactorsequenceDiagram
participant User
participant Sidebar
participant Layout
participant Content Page
User->>Sidebar: Click navigation link
Sidebar->>Layout: Pass selected section and sidebar config
Layout->>Content Page: Render selected content with sidebar and header
Content Page-->>User: Display updated documentation or guide
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
Dashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7651 +/- ##
=======================================
Coverage 56.38% 56.38%
=======================================
Files 908 908
Lines 58218 58218
Branches 4222 4222
=======================================
Hits 32829 32829
Misses 25281 25281
Partials 108 108
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
gregfromstl
force-pushed
the
greg/tool-5063-simplify-payments-docs
branch
from
72913aa to
8ee7b5d
Compare
gregfromstl
force-pushed
the
greg/tool-5063-simplify-payments-docs
branch
from
3dcd60f to
04ccc97
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
apps/portal/src/app/payments/page.mdx (2)
1-14: Trim unused component imports
Callout,OpenSourceCard, andBadgeare imported but never referenced in the file. Keeping dead imports bloats the bundle and will trigger the linter.-import { - Callout, - OpenSourceCard, - ... - Badge -} from "@doc"; +import { + createMetadata, + InstallTabs, + SDKCard, + Grid, + ArticleIconCard, + Tabs, + TabsList, + TabsTrigger, + TabsContent, +} from "@doc";
85-87: Remove unused symbols inside the TypeScript snippet
NATIVE_TOKEN_ADDRESSandtoWeiare imported in the example but never used, which may confuse readers who will look for them later in the code block.-import { Bridge, NATIVE_TOKEN_ADDRESS, toWei } from "thirdweb"; +import { Bridge } from "thirdweb";apps/portal/src/app/payments/sell/page.mdx (1)
1-14: Remove unused component & icon imports
Callout,OpenSourceCard,UnityIcon,DotNetIcon, andUnrealEngineIconare not referenced in this page. Deleting them avoids linter warnings and keeps the MDX lightweight.apps/portal/src/app/payments/custom-data/page.mdx (1)
1-20: Prune unused imports
Callout,OpenSourceCard,UnityIcon,DotNetIcon, andUnrealEngineIconare imported but never used. Drop them to keep the page lean and prevent eslint “unused-vars” noise.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (31)
apps/portal/public/llms.txt(6 hunks)apps/portal/redirects.mjs(2 hunks)apps/portal/src/app/Header.tsx(6 hunks)apps/portal/src/app/engine/v2/layout.tsx(1 hunks)apps/portal/src/app/engine/v3/layout.tsx(1 hunks)apps/portal/src/app/page.tsx(2 hunks)apps/portal/src/app/payments/custom-data/page.mdx(1 hunks)apps/portal/src/app/payments/page.mdx(1 hunks)apps/portal/src/app/payments/products/page.mdx(1 hunks)apps/portal/src/app/payments/sell/page.mdx(1 hunks)apps/portal/src/app/payments/send/page.mdx(1 hunks)apps/portal/src/app/payments/webhooks/page.mdx(1 hunks)apps/portal/src/app/react-native/v5/layout.tsx(1 hunks)apps/portal/src/app/react-native/v5/page.mdx(0 hunks)apps/portal/src/app/react/v5/layout.tsx(1 hunks)apps/portal/src/app/react/v5/page.mdx(0 hunks)apps/portal/src/app/transactions/layout.tsx(1 hunks)apps/portal/src/app/transactions/page.mdx(1 hunks)apps/portal/src/app/transactions/sidebar.tsx(1 hunks)apps/portal/src/app/typescript/v5/layout.tsx(1 hunks)apps/portal/src/app/typescript/v5/page.mdx(0 hunks)apps/portal/src/app/typescript/v5/sidebar.tsx(1 hunks)apps/portal/src/app/unity/v5/layout.tsx(1 hunks)apps/portal/src/app/unreal-engine/layout.tsx(1 hunks)apps/portal/src/app/webhooks/layout.tsx(1 hunks)apps/portal/src/components/Document/Cards/ConnectCard.tsx(0 hunks)apps/portal/src/components/Document/List.module.css(2 hunks)apps/portal/src/components/Document/index.ts(1 hunks)apps/portal/src/components/Layouts/DocLayout.tsx(2 hunks)apps/portal/src/components/others/Sidebar.tsx(6 hunks)apps/portal/src/components/others/TableOfContents.tsx(2 hunks)
💤 Files with no reviewable changes (4)
- apps/portal/src/app/typescript/v5/page.mdx
- apps/portal/src/app/react/v5/page.mdx
- apps/portal/src/app/react-native/v5/page.mdx
- apps/portal/src/components/Document/Cards/ConnectCard.tsx
✅ Files skipped from review due to trivial changes (2)
- apps/portal/src/components/Document/index.ts
- apps/portal/src/app/react-native/v5/layout.tsx
🚧 Files skipped from review as they are similar to previous changes (22)
- apps/portal/src/app/transactions/page.mdx
- apps/portal/src/app/engine/v3/layout.tsx
- apps/portal/src/app/unity/v5/layout.tsx
- apps/portal/src/app/engine/v2/layout.tsx
- apps/portal/src/app/react/v5/layout.tsx
- apps/portal/src/app/unreal-engine/layout.tsx
- apps/portal/src/app/webhooks/layout.tsx
- apps/portal/src/app/typescript/v5/sidebar.tsx
- apps/portal/src/components/Document/List.module.css
- apps/portal/src/app/transactions/sidebar.tsx
- apps/portal/src/app/typescript/v5/layout.tsx
- apps/portal/src/components/others/TableOfContents.tsx
- apps/portal/src/app/Header.tsx
- apps/portal/src/components/Layouts/DocLayout.tsx
- apps/portal/src/app/page.tsx
- apps/portal/src/app/payments/products/page.mdx
- apps/portal/src/app/payments/send/page.mdx
- apps/portal/src/app/payments/webhooks/page.mdx
- apps/portal/public/llms.txt
- apps/portal/src/app/transactions/layout.tsx
- apps/portal/src/components/others/Sidebar.tsx
- apps/portal/redirects.mjs
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).
apps/portal/src/app/payments/page.mdx (13)
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).
Learnt from: saminacodes
PR: thirdweb-dev/js#7543
File: apps/portal/src/app/pay/page.mdx:4-4
Timestamp: 2025-07-07T21:21:47.488Z
Learning: In the thirdweb-dev/js repository, lucide-react icons must be imported with the "Icon" suffix (e.g., ExternalLinkIcon, RocketIcon) as required by the new linting rule, contrary to the typical lucide-react convention of importing without the suffix.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Icons come from `lucide-react` or the project-specific `…/icons` exports – never embed raw SVG.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use `NavLink` (`@/components/ui/NavLink`) for internal navigation so active states are handled automatically.
Learnt from: jnsdls
PR: thirdweb-dev/js#7365
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx:16-17
Timestamp: 2025-06-18T04:30:04.326Z
Learning: Next.js Link component fully supports both internal and external URLs and works appropriately with all standard anchor attributes including target="_blank", rel="noopener noreferrer", etc. Using Link for external URLs is completely appropriate and recommended.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Always import from the central UI library under `@/components/ui/*` – e.g. `import { Button } from "@/components/ui/button"`.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `NavLink` for internal navigation with automatic active states in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.
Learnt from: jnsdls
PR: thirdweb-dev/js#7365
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx:16-17
Timestamp: 2025-06-18T04:27:16.172Z
Learning: Next.js Link component supports external URLs without throwing errors. When used with absolute URLs (like https://...), it behaves like a regular anchor tag without client-side routing, but does not cause runtime crashes or errors as previously believed.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Import UI primitives from `@/components/ui/*` (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Anything that consumes hooks from `@tanstack/react-query` or thirdweb SDKs.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
apps/portal/src/app/payments/custom-data/page.mdx (10)
Learnt from: saminacodes
PR: thirdweb-dev/js#7543
File: apps/portal/src/app/pay/page.mdx:4-4
Timestamp: 2025-07-07T21:21:47.488Z
Learning: In the thirdweb-dev/js repository, lucide-react icons must be imported with the "Icon" suffix (e.g., ExternalLinkIcon, RocketIcon) as required by the new linting rule, contrary to the typical lucide-react convention of importing without the suffix.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Icons come from `lucide-react` or the project-specific `…/icons` exports – never embed raw SVG.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use `NavLink` (`@/components/ui/NavLink`) for internal navigation so active states are handled automatically.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Always import from the central UI library under `@/components/ui/*` – e.g. `import { Button } from "@/components/ui/button"`.
Learnt from: jnsdls
PR: thirdweb-dev/js#7365
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx:16-17
Timestamp: 2025-06-18T04:30:04.326Z
Learning: Next.js Link component fully supports both internal and external URLs and works appropriately with all standard anchor attributes including target="_blank", rel="noopener noreferrer", etc. Using Link for external URLs is completely appropriate and recommended.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `NavLink` for internal navigation with automatic active states in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Import UI primitives from `@/components/ui/*` (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Stick to design-tokens: background (`bg-card`), borders (`border-border`), muted text (`text-muted-foreground`) etc.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
apps/portal/src/app/payments/sell/page.mdx (5)
Learnt from: MananTank
PR: thirdweb-dev/js#7152
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/tokens/shared-page.tsx:41-48
Timestamp: 2025-05-26T16:28:50.772Z
Learning: The `projectMeta` prop is not required for the server-rendered `ContractTokensPage` component in the tokens shared page, unlike some other shared pages where it's needed for consistency.
Learnt from: gregfromstl
PR: thirdweb-dev/js#7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (`packages/thirdweb/src/bridge/Webhook.ts`), the `currencyAmount` field is intentionally typed as `z.number()` while other amount fields use `z.string()` because `currencyAmount` represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (`currencyAmount` vs `amount`) reflects this intentional distinction.
Learnt from: MananTank
PR: thirdweb-dev/js#7177
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_hooks/useTokenPriceData.ts:49-49
Timestamp: 2025-05-27T19:55:25.056Z
Learning: In the ERC20 public pages token price data hook (`useTokenPriceData.ts`), direct array access on `json.data[0]` without optional chaining is intentionally correct and should not be changed to use safety checks.
Learnt from: MananTank
PR: thirdweb-dev/js#7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:255-277
Timestamp: 2025-06-06T23:47:55.122Z
Learning: The `transfer` function from `thirdweb/extensions/erc20` accepts human-readable amounts via the `amount` property and automatically handles conversion to base units (wei) by fetching the token decimals internally. Manual conversion using `toWei()` is not required when using the `amount` property.
Learnt from: MananTank
PR: thirdweb-dev/js#7081
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/assets/create/create-token-page-impl.tsx:110-118
Timestamp: 2025-05-20T18:54:15.781Z
Learning: In the thirdweb dashboard's token asset creation flow, the `transferBatch` function from `thirdweb/extensions/erc20` accepts the raw quantity values from the form without requiring explicit conversion to wei using `toUnits()`. The function appears to handle this conversion internally or is designed to work with the values in the format they're already provided.
🪛 Gitleaks (8.27.2)
apps/portal/src/app/payments/page.mdx
89-89: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
91-91: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
109-109: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
111-111: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
250-250: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
apps/portal/src/app/payments/custom-data/page.mdx
55-55: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
57-57: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
apps/portal/src/app/payments/sell/page.mdx
54-54: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
56-56: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/portal/src/app/payments/sell/page.mdx (2)
1-20: Trim unused imports to avoid dead code & lint noise
Callout,OpenSourceCard,InstallTabs,SDKCard,Grid,ArticleIconCard,ReactIcon,UnityIcon,DotNetIcon, andUnrealEngineIconare imported but never referenced in this file. Keeping them:
- Increases bundle size until the tree-shaker kicks in.
- Trips “unused import” lint rules.
Remove or use them.
-import { - Callout, - OpenSourceCard, - createMetadata, - InstallTabs, - SDKCard, - Grid, - ArticleIconCard, - Tabs, - TabsList, - TabsTrigger, - TabsContent, -} from "@doc"; +import { + createMetadata, + Tabs, + TabsList, + TabsTrigger, + TabsContent, +} from "@doc"; -import { - ReactIcon, - TypeScriptIcon, - UnityIcon, - DotNetIcon, - UnrealEngineIcon, -} from "@/icons"; +import { TypeScriptIcon } from "@/icons";
51-60: Clarify theclientplaceholder to keep the snippet copy-pasteableReaders will hit a “
clientis not defined” error if they copy this example verbatim. Add a short comment or a preceding line that shows whereclientcomes from (e.g.,const client = new PaymentsClient({ … })).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/portal/src/app/payments/products/page.mdx(1 hunks)apps/portal/src/app/payments/sell/page.mdx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/portal/src/app/payments/products/page.mdx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).
apps/portal/src/app/payments/sell/page.mdx (15)
Learnt from: MananTank
PR: thirdweb-dev/js#7152
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/tokens/shared-page.tsx:41-48
Timestamp: 2025-05-26T16:28:50.772Z
Learning: The `projectMeta` prop is not required for the server-rendered `ContractTokensPage` component in the tokens shared page, unlike some other shared pages where it's needed for consistency.
Learnt from: gregfromstl
PR: thirdweb-dev/js#7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (`packages/thirdweb/src/bridge/Webhook.ts`), the `currencyAmount` field is intentionally typed as `z.number()` while other amount fields use `z.string()` because `currencyAmount` represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (`currencyAmount` vs `amount`) reflects this intentional distinction.
Learnt from: MananTank
PR: thirdweb-dev/js#7177
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_hooks/useTokenPriceData.ts:49-49
Timestamp: 2025-05-27T19:55:25.056Z
Learning: In the ERC20 public pages token price data hook (`useTokenPriceData.ts`), direct array access on `json.data[0]` without optional chaining is intentionally correct and should not be changed to use safety checks.
Learnt from: MananTank
PR: thirdweb-dev/js#7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:255-277
Timestamp: 2025-06-06T23:47:55.122Z
Learning: The `transfer` function from `thirdweb/extensions/erc20` accepts human-readable amounts via the `amount` property and automatically handles conversion to base units (wei) by fetching the token decimals internally. Manual conversion using `toWei()` is not required when using the `amount` property.
Learnt from: MananTank
PR: thirdweb-dev/js#7081
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/assets/create/create-token-page-impl.tsx:110-118
Timestamp: 2025-05-20T18:54:15.781Z
Learning: In the thirdweb dashboard's token asset creation flow, the `transferBatch` function from `thirdweb/extensions/erc20` accepts the raw quantity values from the form without requiring explicit conversion to wei using `toUnits()`. The function appears to handle this conversion internally or is designed to work with the values in the format they're already provided.
Learnt from: saminacodes
PR: thirdweb-dev/js#7543
File: apps/portal/src/app/pay/page.mdx:4-4
Timestamp: 2025-07-07T21:21:47.488Z
Learning: In the thirdweb-dev/js repository, lucide-react icons must be imported with the "Icon" suffix (e.g., ExternalLinkIcon, RocketIcon) as required by the new linting rule, contrary to the typical lucide-react convention of importing without the suffix.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Icons come from `lucide-react` or the project-specific `…/icons` exports – never embed raw SVG.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use `NavLink` (`@/components/ui/NavLink`) for internal navigation so active states are handled automatically.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Always import from the central UI library under `@/components/ui/*` – e.g. `import { Button } from "@/components/ui/button"`.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Import UI primitives from `@/components/ui/*` (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Stick to design-tokens: background (`bg-card`), borders (`border-border`), muted text (`text-muted-foreground`) etc.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `NavLink` for internal navigation with automatic active states in dashboard and playground apps
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/components/*.client.tsx : Client components must start with `'use client';` before imports.
🪛 Gitleaks (8.27.2)
apps/portal/src/app/payments/sell/page.mdx
53-53: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
55-55: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/payments/sell/page.mdx (1)
53-55: Static-analysis false positive – safe to ignoreGitleaks flags the token addresses here as “Generic API Key”. They’re publicly visible contract addresses, not secrets, so no action required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring the codebase by renaming and reorganizing various files and components related to the payment system and wallet functionalities, enhancing the structure and readability of the project.
Detailed summary
apps/portal/src/app/paytoapps/portal/src/app/payments./connectto/wallets..mdxand.tsxfiles related to payments and wallet features.Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation
Chores