Skip to content

[SDK] Fix useContractEvents persisting previous data when filters change #7766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

[SDK] Fix useContractEvents persisting previous data when filters change #7766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-ducks-lie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fixed `useContractEvents` persisting previous data when filters change
2 changes: 1 addition & 1 deletion packages/thirdweb/src/react/core/hooks/contract/useContractEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function useContractEvents<
() =>
events?.reduce((acc, curr) => {
// we can use the event hash as a unique identifier?
return `${acc}${curr.hash}_`;
return `${acc}${curr.hash}${curr.topics.join("")}_`;
}, "") || "__all__",
[events],
);
Expand Down
Loading