chore: fix typos in docs #7842
chore: fix typos in docs #7842
Conversation
|
WalkthroughThis change corrects typos in documentation/comments across three TypeScript files. No executable code, signatures, logic, or control flow were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@joeybright53 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
Portal
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/src/wallets/smart/lib/userop.ts (1)
253-253: Fix grammar in comment: “explicitly values” → “explicit values”Small nit to improve readability.
Apply this diff:
- // Check for explicitly values + // Check for explicit valuesapps/portal/src/app/references/components/TDoc/utils/getAllTSReferencesLinkMap.ts (1)
7-7: Polish JSDoc wording and capitalizationUse “set” (matches return type) and capitalize TypeScript.
Apply this diff:
- * Get the map of all valid reference links for typescript packages + * Get the set of all valid reference links for TypeScript packages
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/portal/src/app/references/components/TDoc/utils/getAllTSReferencesLinkMap.ts(1 hunks)packages/thirdweb/src/wallets/smart/lib/signing.ts(1 hunks)packages/thirdweb/src/wallets/smart/lib/userop.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Files:
packages/thirdweb/src/wallets/smart/lib/userop.tsapps/portal/src/app/references/components/TDoc/utils/getAllTSReferencesLinkMap.tspackages/thirdweb/src/wallets/smart/lib/signing.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit Inference Engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
packages/thirdweb/src/wallets/smart/lib/userop.tsapps/portal/src/app/references/components/TDoc/utils/getAllTSReferencesLinkMap.tspackages/thirdweb/src/wallets/smart/lib/signing.ts
packages/thirdweb/src/wallets/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
packages/thirdweb/src/wallets/**: UnifiedWalletandAccountinterfaces in wallet architecture
Support for in-app wallets (social/email login)
Smart wallets with account abstraction
EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Files:
packages/thirdweb/src/wallets/smart/lib/userop.tspackages/thirdweb/src/wallets/smart/lib/signing.ts
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to **/*.{ts,tsx} : Comment only ambiguous logic; avoid restating TypeScript in prose
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
Applied to files:
packages/thirdweb/src/wallets/smart/lib/signing.ts
🔇 Additional comments (1)
packages/thirdweb/src/wallets/smart/lib/signing.ts (1)
184-184: LGTM: typo corrected (“Deploys”)Documentation fix looks good; no functional changes.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| maxPriorityFeePerGas = bundlerGasPrice.maxPriorityFeePerGas; | ||
| } else { | ||
| // Check for explicity values | ||
| // Check for explicitly values |
There was a problem hiding this comment.
While fixing the typo from "explicity" to "explicitly", a grammatical error was introduced. The phrase "explicitly values" incorrectly uses an adverb to modify a noun. The correct form should be "explicit values" (adjective + noun) to properly describe the nature of the values being checked.
| // Check for explicitly values | |
| // Check for explicit values |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
2 participants
Description
This PR fixes several spelling errors in docs:
Fixed spelling in docs from "pacakges" to "packages"
Fixed spelling in docs from "Deployes" to "Deploys"
Fixed spelling in docs from "explicity" to "explicitly"
PR-Codex overview
This PR focuses on correcting typos in comments and documentation across multiple files in the codebase.
Detailed summary
packages/thirdweb/src/wallets/smart/lib/userop.ts.apps/portal/src/app/references/components/TDoc/utils/getAllTSReferencesLinkMap.ts.packages/thirdweb/src/wallets/smart/lib/signing.ts.Summary by CodeRabbit